From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <wangpeiyang1@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<sudongming1@huawei.com>, <xujunsheng@huawei.com>,
<shiyongbang@huawei.com>, <libaihan@huawei.com>,
<jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [PATCH v3 net-next 2/6] net: hibmcge: Add support for rx checksum offload
Date: Thu, 27 Feb 2025 06:47:08 -0800 [thread overview]
Message-ID: <20250227064708.7811dfa7@kernel.org> (raw)
In-Reply-To: <11198621-5c04-4a00-a69e-165e22ebf0e8@huawei.com>
On Thu, 27 Feb 2025 19:28:25 +0800 Jijie Shao wrote:
> rx checksum offload enable:
> device check ok -> CHECKSUM_UNNECESSARY -> stack
> device check fail -> drop
Don't drop packets on csum validation failure.
The stack can easily handle packets with bad csum.
And users will monitor stack metrics for csum errors.
Plus devices are wrong more often than the stack.
next prev parent reply other threads:[~2025-02-27 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 11:55 [PATCH v3 net-next 0/6] Support some enhances features for the HIBMCGE driver Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 1/6] net: hibmcge: Add support for dump statistics Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 2/6] net: hibmcge: Add support for rx checksum offload Jijie Shao
2025-02-25 3:09 ` Jakub Kicinski
2025-02-25 9:00 ` Jijie Shao
2025-02-25 16:23 ` Jakub Kicinski
2025-02-27 11:28 ` Jijie Shao
2025-02-27 14:47 ` Jakub Kicinski [this message]
2025-02-28 1:04 ` Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 3/6] net: hibmcge: Add support for abnormal irq handling feature Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 4/6] net: hibmcge: Add support for mac link exception " Jijie Shao
2025-02-25 3:09 ` Jakub Kicinski
2025-02-25 8:37 ` Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 5/6] net: hibmcge: Add support for BMC diagnose feature Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 6/6] net: hibmcge: Add support for ioctl Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227064708.7811dfa7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).