Re: [PATCH net-next v6 00/14] xsc: ADD Yunsilicon XSC Ethernet Driver

[Jakub Kicinski <kuba@kernel.org>]

On Thu, 27 Feb 2025 16:26:36 +0800 Xin Tian wrote:
> The patch series adds the xsc driver, which will support the YunSilicon
> MS/MC/MV series of network cards. These network cards offer support for
> high-speed Ethernet and RDMA networking, with speeds of up to 200Gbps.
> 
> The Ethernet functionality is implemented by two modules. One is a
> PCI driver(xsc_pci), which provides PCIe configuration,
> CMDQ service (communication with firmware), interrupt handling,
> hardware resource management, and other services, while offering
> common interfaces for Ethernet and future InfiniBand drivers to
> utilize hardware resources. The other is an Ethernet driver(xsc_eth),
> which handles Ethernet interface configuration and data
> transmission/reception.
> 
> - Patches 1-7 implement the PCI driver
> - Patches 8-14 implement the Ethernet driver
> 
> This submission is the first phase, which includes the PF-based Ethernet
> transmit and receive functionality. Once this is merged, we will submit
> additional patches to implement support for other features, such as SR-IOV,
> ethtool support, and a new RDMA driver.

drivers/net/ethernet/yunsilicon/xsc/pci/cmdq.c:525:14-15: WARNING: *_pool_zalloc should be used for mailbox -> buf, instead of *_pool_alloc/memset
drivers/net/ethernet/yunsilicon/xsc/pci/hw.c:40:17-24: WARNING: vzalloc should be used for board_info [ i ], instead of vmalloc/memset
drivers/net/ethernet/yunsilicon/xsc/net/main.c:1946:21-22: WARNING kvmalloc is used to allocate this memory at line 1933
drivers/net/ethernet/yunsilicon/xsc/net/main.c:1968:22-28: ERROR: adapter is NULL but dereferenced.
drivers/net/ethernet/yunsilicon/xsc/net/xsc_eth_tx.c:284:14-21: WARNING: Unsigned expression compared with zero: num_dma < 0
-- 
pw-bot: cr