From: Peter Seiderer <ps.report@gmx.net>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Artem Chernyshev <artem.chernyshev@red-soft.ru>,
Frederic Weisbecker <frederic@kernel.org>,
Nam Cao <namcao@linutronix.de>
Subject: Re: [PATCH net-next v7 6/8] net: pktgen: fix mpls reset parsing
Date: Thu, 27 Feb 2025 14:43:35 +0100 [thread overview]
Message-ID: <20250227144335.6e3af335@gmx.net> (raw)
In-Reply-To: <02e13783-1f87-46a7-9396-96bf17e36a9f@redhat.com>
On Thu, 27 Feb 2025 11:19:33 +0100, Paolo Abeni <pabeni@redhat.com> wrote:
> On 2/24/25 10:22 AM, Peter Seiderer wrote:
> > diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> > index ae5e81e62733..bb13a4591709 100644
> > --- a/net/core/pktgen.c
> > +++ b/net/core/pktgen.c
> > @@ -915,8 +915,13 @@ static ssize_t get_labels(const char __user *buffer,
> >
> > max = min(8, maxlen - i);
> > len = hex32_arg(&buffer[i], max, &tmp);
> > - if (len <= 0)
> > + if (len < 0)
> > return len;
> > +
> > + // return empty list in case of invalid input and/or zero value
>
> I'm sorry for nit picking, but C-99 comments should be avoided
O.k., will change on next patch iteration, thanks for review!
Regards,
Peter
>
> Thanks,
>
> Paolo
>
next prev parent reply other threads:[~2025-02-27 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 9:22 [PATCH net-next v7 0/8] Some pktgen fixes/improvments (part II) Peter Seiderer
2025-02-24 9:22 ` [PATCH net-next v7 1/8] net: pktgen: fix mix of int/long Peter Seiderer
2025-02-24 9:38 ` Peter Seiderer
2025-02-27 10:21 ` Simon Horman
2025-02-24 9:22 ` [PATCH net-next v7 2/8] net: pktgen: remove extra tmp variable (re-use len instead) Peter Seiderer
2025-02-24 9:22 ` [PATCH net-next v7 3/8] net: pktgen: remove some superfluous variable initializing Peter Seiderer
2025-02-24 9:22 ` [PATCH net-next v7 4/8] net: pktgen: fix mpls maximum labels list parsing Peter Seiderer
2025-02-27 10:24 ` Paolo Abeni
2025-02-27 13:42 ` Peter Seiderer
2025-02-24 9:22 ` [PATCH net-next v7 5/8] net: pktgen: fix access outside of user given buffer in pktgen_if_write() Peter Seiderer
2025-02-24 9:22 ` [PATCH net-next v7 6/8] net: pktgen: fix mpls reset parsing Peter Seiderer
2025-02-27 10:19 ` Paolo Abeni
2025-02-27 13:43 ` Peter Seiderer [this message]
2025-02-24 9:22 ` [PATCH net-next v7 7/8] net: pktgen: remove all superfluous index assignements Peter Seiderer
2025-02-24 9:22 ` [PATCH net-next v7 8/8] selftest: net: add proc_net_pktgen Peter Seiderer
2025-02-27 10:21 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227144335.6e3af335@gmx.net \
--to=ps.report@gmx.net \
--cc=artem.chernyshev@red-soft.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).