From: Jakub Kicinski <kuba@kernel.org>
To: Philipp Stanner <phasta@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Huacai Chen <chenhuacai@kernel.org>,
Yanteng Si <si.yanteng@linux.dev>,
Yinggang Gu <guyinggang@loongson.cn>,
Feiyang Chen <chenfeiyang@loongson.cn>,
Philipp Stanner <pstanner@redhat.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Qing Zhang <zhangqing@loongson.cn>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>, Henry Chen <chenx97@aosc.io>
Subject: Re: [PATCH net-next v4 1/4] stmmac: loongson: Pass correct arg to PCI function
Date: Thu, 27 Feb 2025 18:35:45 -0800 [thread overview]
Message-ID: <20250227183545.0848dd61@kernel.org> (raw)
In-Reply-To: <20250226085208.97891-2-phasta@kernel.org>
On Wed, 26 Feb 2025 09:52:05 +0100 Philipp Stanner wrote:
> pcim_iomap_regions() should receive the driver's name as its third
> parameter, not the PCI device's name.
>
> Define the driver name with a macro and use it at the appropriate
> places, including pcim_iomap_regions().
>
> Cc: stable@vger.kernel.org # v5.14+
> Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
Since you sent this as a fix (which.. yea.. I guess.. why not..)
I'll apply it to the fixes tree. But then the other patches have
to wait and be reposted next Thu. The fixes are merged with net-next
every Thu, but since this series was tagged as net-next I missed
it in today's cross merge :(
next prev parent reply other threads:[~2025-02-28 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 8:52 [PATCH net-next v4 0/4] stmmac: Several PCI-related improvements Philipp Stanner
2025-02-26 8:52 ` [PATCH net-next v4 1/4] stmmac: loongson: Pass correct arg to PCI function Philipp Stanner
2025-02-28 2:35 ` Jakub Kicinski [this message]
2025-02-28 9:26 ` Philipp Stanner
2025-02-28 22:03 ` Jakub Kicinski
2025-02-26 8:52 ` [PATCH net-next v4 2/4] stmmac: loongson: Remove surplus loop Philipp Stanner
2025-02-26 8:52 ` [PATCH net-next v4 3/4] stmmac: Remove pcim_* functions for driver detach Philipp Stanner
2025-02-26 8:52 ` [PATCH net-next v4 4/4] stmmac: Replace deprecated PCI functions Philipp Stanner
2025-02-28 2:40 ` [PATCH net-next v4 0/4] stmmac: Several PCI-related improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227183545.0848dd61@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=chenx97@aosc.io \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guyinggang@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phasta@kernel.org \
--cc=pstanner@redhat.com \
--cc=si.yanteng@linux.dev \
--cc=stable@vger.kernel.org \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).