From: Breno Leitao <leitao@debian.org>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
Breno Leitao <leitao@debian.org>,
kernel-team@meta.com
Subject: [PATCH net-next v2 2/8] netconsole: Make boolean comparison consistent
Date: Fri, 28 Feb 2025 04:50:18 -0800 [thread overview]
Message-ID: <20250228-netcons_current-v2-2-f53ff79a0db2@debian.org> (raw)
In-Reply-To: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org>
Convert the current state assignment to use explicit boolean conversion,
making the code more robust and easier to read. This change adds a
double-negation operator to ensure consistent boolean conversion as
suggested by Paolo[1].
This approach aligns with the existing pattern used in
sysdata_cpu_nr_enabled_show().
Link: https://lore.kernel.org/all/7309e760-63b0-4b58-ad33-2fb8db361141@redhat.com/ [1]
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/netconsole.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index c086e2fe51f87..698dbbea2713f 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -850,7 +850,7 @@ static ssize_t sysdata_cpu_nr_enabled_store(struct config_item *item,
return ret;
mutex_lock(&dynamic_netconsole_mutex);
- curr = nt->sysdata_fields & SYSDATA_CPU_NR;
+ curr = !!(nt->sysdata_fields & SYSDATA_CPU_NR);
if (cpu_nr_enabled == curr)
/* no change requested */
goto unlock_ok;
--
2.43.5
next prev parent reply other threads:[~2025-02-28 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 12:50 [PATCH net-next v2 0/8] netconsole: Add taskname sysdata support Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 1/8] netconsole: prefix CPU_NR sysdata feature with SYSDATA_ Breno Leitao
2025-02-28 12:50 ` Breno Leitao [this message]
2025-03-04 11:50 ` [PATCH net-next v2 2/8] netconsole: Make boolean comparison consistent Simon Horman
2025-02-28 12:50 ` [PATCH net-next v2 3/8] netconsole: refactor CPU number formatting into separate function Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 4/8] netconsole: add taskname to extradata entry count Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 5/8] netconsole: add configfs controls for taskname sysdata feature Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 6/8] netconsole: add task name to extra data fields Breno Leitao
2025-03-04 11:52 ` Simon Horman
2025-02-28 12:50 ` [PATCH net-next v2 7/8] netconsole: docs: document the task name feature Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 8/8] netconsole: selftest: add task name append testing Breno Leitao
2025-03-04 14:50 ` [PATCH net-next v2 0/8] netconsole: Add taskname sysdata support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228-netcons_current-v2-2-f53ff79a0db2@debian.org \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).