From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
Ahmed Zaki <ahmed.zaki@intel.com>,
willemb@google.com, Madhu Chittim <madhu.chittim@intel.com>,
Simon Horman <horms@kernel.org>,
Samuel Salin <Samuel.salin@intel.com>
Subject: Re: [PATCH net v2] idpf: synchronize pending IRQs after disable
Date: Fri, 28 Feb 2025 14:40:51 -0800 [thread overview]
Message-ID: <20250228144051.4c3064b0@kernel.org> (raw)
In-Reply-To: <20250227211610.1154503-1-anthony.l.nguyen@intel.com>
On Thu, 27 Feb 2025 13:16:09 -0800 Tony Nguyen wrote:
> IDPF deinits all interrupts in idpf_vport_intr_deinit() by first disabling
> the interrupt registers in idpf_vport_intr_dis_irq_all(), then later on frees
> the irqs in idpf_vport_intr_rel_irq().
>
> Prevent any races by waiting for pending IRQ handler after it is disabled.
> This will ensure the IRQ is cleanly freed afterwards.
You need to explain what is racing with what. Most drivers are fine
with just ordering the teardown carefully. What is racing with the IRQ,
and why can idpf_vport_intr_dis_irq_all() not be moved after that thing
is disabled.
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-28 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 21:16 [PATCH net v2] idpf: synchronize pending IRQs after disable Tony Nguyen
2025-02-28 22:40 ` Jakub Kicinski [this message]
2025-02-28 23:59 ` Ahmed Zaki
2025-03-01 0:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228144051.4c3064b0@kernel.org \
--to=kuba@kernel.org \
--cc=Samuel.salin@intel.com \
--cc=ahmed.zaki@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).