From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64CB01BD9C9; Sat, 1 Mar 2025 09:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740822840; cv=none; b=c9JSGlGb9ofFM2Ldl0n/LHwQEo7nqtc677Or6DGg6o1zaVcB9XOuEpgNg08qukpdBC5TZynsyeOfH27LyZlIBGQK0MH4D7L1XJtPoKqNDmnyIa1hRrP6DqegI0VMO9InernlyRST5xO9qvphNJr2E/k1skKIFtlFV1eoHvKsgHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740822840; c=relaxed/simple; bh=eqbPsm3op//La9k9/z7JupuB3rmnWYnIHpb/PIC4tVQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tb4IUzPrG6flGmQVnWwjhauQGrnqomfMHbN1h6unEpZbov0LlBZXm6xmHv/HOsTqoJRHucHArzodmOYI3zJ0SLGa4jABbROjtGGTuVPrf3PyWiqMq3RhI9h1FQqMipbxseiZ5T4HsmlBN6u2gEo9fOOx2kCAC8eVN8gHlvHZZVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=KD+efzw6; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="KD+efzw6" Received: by mail.gandi.net (Postfix) with ESMTPSA id DC07B204D3; Sat, 1 Mar 2025 09:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740822835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XRJEoxt60O83ppaAV+LL/miyh/fpyrDqP7zxjnOiPVo=; b=KD+efzw6Gx9aL3vkkXqp2yVJUaIn7T+leY97gmNLuJrC8gFLPvpP3aSeeLkw1AlfHbcbij e5UBkq/wk9Q155/bzKuYsJ/SBwGFn7UfssPcxyvTJvqW7GdfBsftbTBqR8BYsUdwIpVely 504F/0upXLq8ow18saZ62POCVbqVwiu68+ab24Y4a8wk5TB51PTFj3XirKt2Nd/utMZmue OnG0iBd9DfBAyf1hyJm+j3q4BwhQUGHtdSr0An9bvQ85dwOWnm5IyFxNXzpCBuGM0LG+Ty ywdqn5u9/h6xltqAc/Avup1TYVA2BcNPUi+ebq1tNeCa9re5IibnNxPG4IEvkw== Date: Sat, 1 Mar 2025 10:53:52 +0100 From: Maxime Chevallier To: Jakub Kicinski Cc: davem@davemloft.net, Andrew Lunn , Eric Dumazet , Paolo Abeni , Heiner Kallweit , Parthiban Veerasooran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Oleksij Rempel , Simon Horman , Romain Gantois , Piergiorgio Beruto Subject: Re: [PATCH net 2/2] net: ethtool: netlink: Pass a context for default ethnl notifications Message-ID: <20250301105352.2951af4c@fedora.home> In-Reply-To: <20250228182440.3c7f4709@kernel.org> References: <20250227182454.1998236-1-maxime.chevallier@bootlin.com> <20250227182454.1998236-3-maxime.chevallier@bootlin.com> <20250228182440.3c7f4709@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdelvdelkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfohfogggtgfesthejredtredtvdenucfhrhhomhepofgrgihimhgvucevhhgvvhgrlhhlihgvrhcuoehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeegveeltddvveeuhefhvefhlefhkeevfedtgfeiudefffeiledttdfgfeeuhfeukeenucfkphepvdgrtddumegtsgduleemkegugegtmeelfhdttdemsggtvddumeekkeelleemheegtdgtmegvheelvgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemtggsudelmeekugegtgemlehftddtmegstgdvudemkeekleelmeehgedttgemvgehlegvpdhhvghlohepfhgvughorhgrrdhhohhmvgdpmhgrihhlfhhrohhmpehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedvtddprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegrnhgurhgvfieslhhunhhnrdgthhdprhgtphhtthhopegvughum hgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehhkhgrlhhlfigvihhtudesghhmrghilhdrtghomhdprhgtphhtthhopehprghrthhhihgsrghnrdhvvggvrhgrshhoohhrrghnsehmihgtrhhotghhihhprdgtohhmpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-GND-Sasl: maxime.chevallier@bootlin.com On Fri, 28 Feb 2025 18:24:40 -0800 Jakub Kicinski wrote: > On Thu, 27 Feb 2025 19:24:52 +0100 Maxime Chevallier wrote: > > The only relevant user for now is PLCA, and it very likely that we never > > ended-up in a situation where the follow-up notif wasn't targeting the > > correct PHY as : > > PLCA uses the ethnl_default_* handlers but it seems to operate on PHYs > now. How does the dump work? Shoehorning the PHY support into > the ethnl_default_* handlers is starting to look pretty messy. I agree, that's the less ugly quick solution I could think of :( So maybe we need some generic PHY dump support for all PHY commands ? I should probably re-send patch 1 only to fix the crash, and rework the dump/notify for PHY commands separately if this is OK for you ? Maxime