* [PATCH] e1000: Adicionado const para melhorar a segurança do código
@ 2025-03-03 13:11 joaomboni
2025-03-03 13:48 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: joaomboni @ 2025-03-03 13:11 UTC (permalink / raw)
To: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni
Cc: intel-wired-lan, netdev, linux-kernel, joaomboni
Signed-off-by: joaomboni <joaoboni017@gmail.com>
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 3f089c3d47b2..96bc85f09aaf 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -9,7 +9,7 @@
#include <linux/if_vlan.h>
char e1000_driver_name[] = "e1000";
-static char e1000_driver_string[] = "Intel(R) PRO/1000 Network Driver";
+static const char e1000_driver_string[] = "Intel(R) PRO/1000 Network Driver";
static const char e1000_copyright[] = "Copyright (c) 1999-2006 Intel Corporation.";
/* e1000_pci_tbl - PCI Device ID Table
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000: Adicionado const para melhorar a segurança do código
2025-03-03 13:11 [PATCH] e1000: Adicionado const para melhorar a segurança do código joaomboni
@ 2025-03-03 13:48 ` Andrew Lunn
2025-03-03 23:31 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2025-03-03 13:48 UTC (permalink / raw)
To: joaomboni
Cc: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, intel-wired-lan, netdev, linux-kernel
On Mon, Mar 03, 2025 at 10:11:55AM -0300, joaomboni wrote:
> Signed-off-by: joaomboni <joaoboni017@gmail.com>
Sorry, but the Subject: line needs to be in English.
And the name in Signed-off-by: needs to be a real name.
The code change itself looks sensible.
Andrew
---
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] e1000: Adicionado const para melhorar a segurança do código
2025-03-03 13:48 ` Andrew Lunn
@ 2025-03-03 23:31 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2025-03-03 23:31 UTC (permalink / raw)
To: Andrew Lunn
Cc: joaomboni, anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev,
davem, edumazet, pabeni, intel-wired-lan, netdev, linux-kernel
On Mon, 3 Mar 2025 14:48:46 +0100 Andrew Lunn wrote:
> Sorry, but the Subject: line needs to be in English.
>
> And the name in Signed-off-by: needs to be a real name.
>
> The code change itself looks sensible.
If only we were also LLMs, not just humans, we could read commits
in any language!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-03 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-03 13:11 [PATCH] e1000: Adicionado const para melhorar a segurança do código joaomboni
2025-03-03 13:48 ` Andrew Lunn
2025-03-03 23:31 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).