From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <edumazet@google.com>
Cc: <davem@davemloft.net>, <eric.dumazet@gmail.com>,
<horms@kernel.org>, <kuba@kernel.org>, <kuniyu@amazon.com>,
<ncardwell@google.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <wanghai38@huawei.com>
Subject: Re: [PATCH v2 net-next 5/6] tcp: remove READ_ONCE(req->ts_recent)
Date: Mon, 3 Mar 2025 15:28:33 -0800 [thread overview]
Message-ID: <20250303232833.54343-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250301201424.2046477-6-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Sat, 1 Mar 2025 20:14:23 +0000
> After commit 8d52da23b6c6 ("tcp: Defer ts_recent changes
> until req is owned"), req->ts_recent is not changed anymore.
>
> It is set once in tcp_openreq_init(), bpf_sk_assign_tcp_reqsk()
> or cookie_tcp_reqsk_alloc() before the req can be seen by other
> cpus/threads.
>
> This completes the revert of eba20811f326 ("tcp: annotate
> data-races around tcp_rsk(req)->ts_recent").
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2025-03-03 23:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 20:14 [PATCH v2 net-next 0/6] tcp: misc changes Eric Dumazet
2025-03-01 20:14 ` [PATCH v2 net-next 1/6] tcp: add a drop_reason pointer to tcp_check_req() Eric Dumazet
2025-03-03 8:27 ` Jason Xing
2025-03-03 23:21 ` Kuniyuki Iwashima
2025-03-01 20:14 ` [PATCH v2 net-next 2/6] tcp: add four drop reasons " Eric Dumazet
2025-03-03 8:55 ` Jason Xing
2025-03-03 23:26 ` Kuniyuki Iwashima
2025-03-01 20:14 ` [PATCH v2 net-next 3/6] tcp: convert to dev_net_rcu() Eric Dumazet
2025-03-01 20:14 ` [PATCH v2 net-next 4/6] net: gro: convert four dev_net() calls Eric Dumazet
2025-03-01 20:14 ` [PATCH v2 net-next 5/6] tcp: remove READ_ONCE(req->ts_recent) Eric Dumazet
2025-03-03 10:49 ` Jason Xing
2025-03-03 23:28 ` Kuniyuki Iwashima [this message]
2025-03-01 20:14 ` [PATCH v2 net-next 6/6] tcp: tcp_set_window_clamp() cleanup Eric Dumazet
2025-03-03 10:46 ` Jason Xing
2025-03-03 23:33 ` Kuniyuki Iwashima
2025-03-04 1:00 ` [PATCH v2 net-next 0/6] tcp: misc changes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303232833.54343-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).