From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Arinzon <darinzon@amazon.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"Woodhouse, David" <dwmw@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
Saeed Bshara <saeedb@amazon.com>, "Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>,
"Machnikowski, Maciek" <maciek@machnikowski.net>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [PATCH v8 net-next 4/5] net: ena: PHC stats through sysfs
Date: Tue, 4 Mar 2025 14:58:57 -0800 [thread overview]
Message-ID: <20250304145857.61a3bd6e@kernel.org> (raw)
In-Reply-To: <21fe01f0-7882-46b8-8e7c-8884f4e803f6@lunn.ch>
On Tue, 4 Mar 2025 22:07:39 +0100 Andrew Lunn wrote:
> I've not been following previous versions of this patch, so i could be
> repeating questions already asked....
>
> ena_adapter represents a netdev?
>
> /* adapter specific private data structure */
> struct ena_adapter {
> struct ena_com_dev *ena_dev;
> /* OS defined structs */
> struct net_device *netdev;
>
> So why are you not using the usual statistics interface for a netdev?
I asked them to do this.
They are using a PTP device as a pure clock. The netdev doesn't support
any HW timestamping, so none of the stats are related to packets.
The PTP clock could as well be attached to a storage PCIe device.
In that way it's more like the OCP PTP driver or other pure clocks
in my eyes. And such drivers use sysfs, given they have no netdev.
next prev parent reply other threads:[~2025-03-04 22:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 19:04 [PATCH v8 net-next 0/5] PHC support in ENA driver David Arinzon
2025-03-04 19:05 ` [PATCH v8 net-next 1/5] net: ena: Add PHC support in the " David Arinzon
2025-03-04 19:05 ` [PATCH v8 net-next 2/5] net: ena: PHC silent reset David Arinzon
2025-03-04 19:05 ` [PATCH v8 net-next 3/5] net: ena: PHC enable through sysfs David Arinzon
2025-03-04 19:05 ` [PATCH v8 net-next 4/5] net: ena: PHC stats " David Arinzon
2025-03-04 21:07 ` Andrew Lunn
2025-03-04 22:58 ` Jakub Kicinski [this message]
2025-03-05 15:33 ` Andrew Lunn
2025-03-06 2:36 ` Jakub Kicinski
2025-03-06 7:15 ` Leon Romanovsky
2025-03-06 15:40 ` Andrew Lunn
2025-03-06 17:31 ` Leon Romanovsky
2025-03-26 15:39 ` Arinzon, David
2025-03-04 19:05 ` [PATCH v8 net-next 5/5] net: ena: Add PHC documentation David Arinzon
2025-03-04 21:10 ` Andrew Lunn
2025-03-05 12:50 ` Arinzon, David
2025-03-05 12:59 ` [EXTERNAL] " David Woodhouse
2025-03-05 15:35 ` Andrew Lunn
2025-03-05 17:52 ` Leon Romanovsky
2025-03-26 15:32 ` Arinzon, David
2025-03-27 11:15 ` Leon Romanovsky
2025-03-27 12:01 ` David Woodhouse
2025-04-01 8:02 ` David Woodhouse
2025-04-01 8:46 ` David Woodhouse
2025-04-02 16:23 ` Jakub Kicinski
2025-04-02 19:38 ` Leon Romanovsky
2025-04-07 7:01 ` Arinzon, David
2025-04-07 14:02 ` Andrew Lunn
2025-04-07 16:27 ` Jakub Kicinski
2025-04-08 14:47 ` Richard Cochran
2025-04-08 15:24 ` Jakub Kicinski
2025-04-10 4:07 ` Richard Cochran
2025-04-10 16:01 ` Jakub Kicinski
2025-03-04 23:00 ` [PATCH v8 net-next 0/5] PHC support in ENA driver Jakub Kicinski
2025-03-05 6:34 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304145857.61a3bd6e@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=amitbern@amazon.com \
--cc=andrew@lunn.ch \
--cc=benh@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=edumazet@google.com \
--cc=evgenys@amazon.com \
--cc=evostrov@amazon.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=maciek@machnikowski.net \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=vadim.fedorenko@linux.dev \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).