From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D14F28D06E; Tue, 4 Mar 2025 16:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741104059; cv=none; b=bopsjqtIx1sESkmOKuaqbjLOeMDzHD/ZQM0U6FxMp7idfNN677v2geBMGH4TbzbnS5lCiOwP84rH+82W45ulQbUMO8/rsuZcBo6GT5hpUYLKacQqIWCuQr5RkRjD4Ogk49pKZLu14Auo99DIwB+rVnpYqZicn40CJ0LZdA3c998= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741104059; c=relaxed/simple; bh=pPjIO747FKL6jAHmMKeBPAAnLzptVY1ZNkFDQcUSYTM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JtCZb76chQiEC+VPtKyH1RxxscMvlUj9FhR0DGyi3D3rH6n8ng8Vhs8pH3z9Lp6s/ISphYIviE+VUDveJ/n/TsfKBoSznV49Q+hNTt2WI7vzp3SCDjmU0rYMbLYoXy2Yzgp03xCMibwv0bq/aamll/UeabYDbySY/sxkuwVcvXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=CRD59RSF; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="CRD59RSF" Received: by mail.gandi.net (Postfix) with ESMTPSA id 7457944333; Tue, 4 Mar 2025 16:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1741104055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RUl0n/50RU5tg+1nlfKABzZ6a5bn6YeoemF/OpOiw6s=; b=CRD59RSFJibwTubuGWUQH+rVsIbGqXDyu51P/eZhUt9/BJxv4rqmXrkswy+ZozaZ7jbPhR ih8ctUWP+aojNtJO5UQjydr7NFcaGbB3qpQ6id1jpQ7eZpo+HTvINN/r3RREvuzQKk50CW twW8YtQfgnmMZ3UCEi0WtzEQwWlH5BxwpFGO3h/m48VpuRrPkhORZa2QB8m0OQ3+UGVBPh A8Zhw4yrKhwwMoxwAKHsmLJLHKLr14gnJf4o80Z4Tmxdrg5AokJzlP2Yg5p81q8bUmp/sW vSIhsihKHDwUfHADuuY9YtIK0JpRLJ92wVqH/uAVDB90UPMnYo9SDG0GzD6vzQ== Date: Tue, 4 Mar 2025 17:00:51 +0100 From: Kory Maincent To: Maxime Chevallier Cc: davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Russell King , Vladimir Oltean , Oleksij Rempel , Simon Horman , Romain Gantois , Piergiorgio Beruto Subject: Re: [PATCH net] net: ethtool: Set the req_info->dev on DUMP requests for each dev Message-ID: <20250304170051.607097e9@kmaincent-XPS-13-7390> In-Reply-To: <20250302162137.698092-1-maxime.chevallier@bootlin.com> References: <20250302162137.698092-1-maxime.chevallier@bootlin.com> Organization: bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutddvgeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtqhertdertdejnecuhfhrohhmpefmohhrhicuofgrihhntggvnhhtuceokhhorhihrdhmrghinhgtvghnthessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgfdutdefvedtudegvefgvedtgfdvhfdtueeltefffefffffhgfetkedvfeduieeinecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehkmhgrihhntggvnhhtqdgirffuqddufedqjeefledtpdhmrghilhhfrhhomhepkhhorhihrdhmrghinhgtvghnthessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepvddupdhrtghpthhtohepmhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomhdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtoheprghnughrvgifsehluhhnnhdrtghhpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhop egvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehhkhgrlhhlfigvihhtudesghhmrghilhdrtghomhdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-GND-Sasl: kory.maincent@bootlin.com On Sun, 2 Mar 2025 17:21:36 +0100 Maxime Chevallier wrote: > There are a few netlink commands that rely on the req_info->dev field > being populated by ethnl in their ->prepare_data() and ->fill_reply(). >=20 > For a regular GET request, this will be set by ethnl_default_parse(), > which calls ethnl_parse_header_dev_get(). >=20 > In the case of a DUMP request, the ->prepare_data() and ->fill_reply() > callbacks will be called with the req_info->dev being NULL, which can > cause discrepancies in the behaviour between GET and DUMP results. >=20 > The main impact is that ethnl_req_get_phydev() will not find any > phy_device, impacting : > - plca > - pse-pd > - stats >=20 > Some other commands rely on req_info->dev, namely : > - coalesce in ->fill_reply to look for an irq_moder >=20 > Although cable_test and tunnels also rely on req_info->dev being set, > that's not a problem for these commands as : > - cable_test doesn't support DUMP > - tunnels rolls its own ->dumpit (and sets dev in the req_info). > - phy also has its own ->dumpit >=20 > All other commands use reply_data->dev (probably the correct way of > doing things) and aren't facing this issue. >=20 > Simply set the dev in the req_info context when iterating to dump each > dev. >=20 > Fixes: c15e065b46dc ("net: ethtool: Allow passing a phy index for some > commands") Signed-off-by: Maxime Chevallier > --- >=20 > Fixes tag targets the phy-index commit, as it introduced a change in > behaviour for PLCA. From what I can tell, coalesce never correctly > detected irq_moder in DUMP requests. >=20 > We could also consider fixing all individual commands that use > req_info->dev, however I'm not actually sure it's incorrect to do so, > feel free to correct me though. >=20 > Maxime >=20 > net/ethtool/netlink.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c > index b4c45207fa32..de967961d8fe 100644 > --- a/net/ethtool/netlink.c > +++ b/net/ethtool/netlink.c > @@ -582,6 +582,7 @@ static int ethnl_default_dumpit(struct sk_buff *skb, > dev_hold(dev); > rcu_read_unlock(); > =20 > + ctx->req_info->dev =3D dev; I would rather put it in ethnl_default_dump_one() before ethnl_init_reply_data() call. With this change: Reviewed-by: Kory Maincent Tested-by: Kory Maincent Thank you! > ret =3D ethnl_default_dump_one(skb, dev, ctx, > genl_info_dump(cb));=20 > rcu_read_lock(); --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com