From: Simon Horman <horms@kernel.org>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH iwl-next v3] igc: Change Tx mode for MQPRIO offloading
Date: Tue, 4 Mar 2025 17:30:21 +0000 [thread overview]
Message-ID: <20250304173021.GH3666230@kernel.org> (raw)
In-Reply-To: <20250303-igc_mqprio_tx_mode-v3-1-0efce85e6ae0@linutronix.de>
On Mon, Mar 03, 2025 at 10:16:33AM +0100, Kurt Kanzenbach wrote:
> The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
> this mode the hardware uses four packet buffers and considers queue
> priorities.
>
> In order to harmonize the TAPRIO implementation with MQPRIO, switch to the
> regular TSN Tx mode. This mode also uses four packet buffers and considers
> queue priorities. In addition to the legacy mode, transmission is always
> coupled to Qbv. The driver already has mechanisms to use a dummy schedule
> of 1 second with all gates open for ETF. Simply use this for MQPRIO too.
>
> This reduces code and makes it easier to add support for frame preemption
> later.
>
> While at it limit the netdev_tc calls to MQPRIO only.
Hi Kurt,
Can this part be broken out into a separate patch?
It seems so to me, but perhaps I'm missing something.
The reason that I ask is that this appears to be a good portion of the
change, and doing so would make the code changes for main part of the
patch, as per the description prior to the line above, clearer IMHO.
>
> Tested on i225 with real time application using high priority queue, iperf3
> using low priority queue and network TAP device.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
...
next prev parent reply other threads:[~2025-03-04 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 9:16 [PATCH iwl-next v3] igc: Change Tx mode for MQPRIO offloading Kurt Kanzenbach
2025-03-03 9:22 ` Abdul Rahim, Faizal
2025-03-04 17:30 ` Simon Horman [this message]
2025-03-05 8:16 ` Kurt Kanzenbach
2025-03-07 15:02 ` Vladimir Oltean
2025-03-11 8:03 ` Abdul Rahim, Faizal
2025-03-13 13:39 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304173021.GH3666230@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=faizal.abdul.rahim@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).