From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH net v1] netmem: prevent TX of unreadable skbs
Date: Wed, 5 Mar 2025 19:11:53 -0800 [thread overview]
Message-ID: <20250305191153.6d899a00@kernel.org> (raw)
In-Reply-To: <20250304234924.1583687-1-almasrymina@google.com>
On Tue, 4 Mar 2025 23:49:24 +0000 Mina Almasry wrote:
> @@ -3914,6 +3914,9 @@ static struct sk_buff *validate_xmit_skb(struct sk_buff *skb, struct net_device
>
> skb = validate_xmit_xfrm(skb, features, again);
>
> + if (!skb_frags_readable(skb))
> + goto out_kfree_skb;
I'd put this new check at the beginning rather than the end.
Feeding unreadable packets into GSO will not result in
much happiness.
prev parent reply other threads:[~2025-03-06 3:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 23:49 [PATCH net v1] netmem: prevent TX of unreadable skbs Mina Almasry
2025-03-06 3:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305191153.6d899a00@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).