From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Saeed Mahameed <saeed@kernel.org>,
David Ahern <dsahern@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Jakub Kicinski <kuba@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
Aron Silverton <aron.silverton@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Dave Jiang <dave.jiang@intel.com>,
Christoph Hellwig <hch@infradead.org>,
Itay Avraham <itayavr@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Leonid Bloch <lbloch@nvidia.com>,
linux-cxl@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
"Nelson, Shannon" <shannon.nelson@amd.com>
Subject: Re: [PATCH v5 0/8] Introduce fwctl subystem
Date: Thu, 6 Mar 2025 09:29:16 +0200 [thread overview]
Message-ID: <20250306072916.GQ1955273@unreal> (raw)
In-Reply-To: <20250305232154.GB354511@nvidia.com>
On Wed, Mar 05, 2025 at 07:21:54PM -0400, Jason Gunthorpe wrote:
> On Wed, Mar 05, 2025 at 12:41:35PM -0800, Saeed Mahameed wrote:
>
> > How do you imagine this driver/core structure should look like? Who
> > will be the top dir maintainer?
>
> I would set something like this up more like DRM. Every driver
> maintainer gets commit rights, some rules about no uAPIs, or at least
> other acks before merging uAPI. Use the tree for staging shared
> branches.
>
> Driver maintainers with the most commits per cycle does the PR or
> something like that.
>
> There is no subsystem or cross-driver entanglement so there is no real
> need for gatekeeping.
Yes, it can be structured like you proposed too or/and combined with my
idea https://lore.kernel.org/netdev/20250303150015.GA1926949@unreal/
The most important part is that it needs to be group of maintainers.
>
> It would be a good opportunity to help more people engage with the
> kernel process and learn the full maintainer flow.
>
> > It should be something that is tightly coupled with aux, currently
> > aux is under drivers/base/auxiliary.c I think it should move to
> > drivers/aux/auxiliary.c and device drivers should implement their
> > own aux buses, WH access APIs and probing/init logic under that
> > directory e.g: drivers/aux/mlx5/..
>
> That makes sense to me. I would expect everything in this collection
> to be PCI drivers spawing aux devices.
>
> drivers/aux_core/ or something like that, perhaps?
I like Saeed's proposal "drivers/aux/", it is more short and catchy.
Thanks
>
> Jason
>
next prev parent reply other threads:[~2025-03-06 7:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 0:26 [PATCH v5 0/8] Introduce fwctl subystem Jason Gunthorpe
2025-02-28 0:26 ` [PATCH v5 1/8] fwctl: Add basic structure for a class subsystem with a cdev Jason Gunthorpe
2025-02-28 0:26 ` [PATCH v5 2/8] fwctl: Basic ioctl dispatch for the character device Jason Gunthorpe
2025-02-28 0:26 ` [PATCH v5 3/8] fwctl: FWCTL_INFO to return basic information about the device Jason Gunthorpe
2025-02-28 0:26 ` [PATCH v5 4/8] taint: Add TAINT_FWCTL Jason Gunthorpe
2025-02-28 0:26 ` [PATCH v5 5/8] fwctl: FWCTL_RPC to execute a Remote Procedure Call to device firmware Jason Gunthorpe
2025-02-28 0:26 ` [PATCH v5 6/8] fwctl: Add documentation Jason Gunthorpe
2025-03-15 2:53 ` Bagas Sanjaya
2025-02-28 0:26 ` [PATCH v5 7/8] fwctl/mlx5: Support for communicating with mlx5 fw Jason Gunthorpe
2025-03-02 12:11 ` Leon Romanovsky
2025-03-04 17:50 ` Jason Gunthorpe
2025-02-28 0:26 ` [PATCH v5 8/8] mlx5: Create an auxiliary device for fwctl_mlx5 Jason Gunthorpe
2025-03-02 12:09 ` Leon Romanovsky
2025-03-04 1:53 ` [PATCH v5 0/8] Introduce fwctl subystem Jakub Kicinski
2025-03-04 14:00 ` Jason Gunthorpe
2025-03-04 17:59 ` Saeed Mahameed
2025-03-05 0:42 ` Jakub Kicinski
2025-03-05 13:32 ` Jason Gunthorpe
2025-03-05 13:43 ` Leon Romanovsky
2025-03-05 15:08 ` Jiri Pirko
2025-03-05 15:22 ` Leon Romanovsky
2025-03-05 15:56 ` Jiri Pirko
2025-03-05 18:17 ` David Ahern
2025-03-05 18:28 ` Leon Romanovsky
2025-03-05 20:41 ` Saeed Mahameed
2025-03-05 23:21 ` Jason Gunthorpe
2025-03-06 7:29 ` Leon Romanovsky [this message]
2025-03-11 11:23 ` David Ahern
2025-03-11 13:59 ` Leon Romanovsky
2025-03-12 9:31 ` David Ahern
2025-03-12 10:34 ` Stanislav Fomichev
2025-03-14 22:34 ` David Ahern
2025-03-16 7:34 ` Stanislav Fomichev
2025-03-17 12:30 ` Jason Gunthorpe
2025-03-11 14:27 ` Nelson, Shannon
2025-03-13 12:30 ` David Ahern
2025-03-13 12:48 ` Leon Romanovsky
2025-03-13 19:59 ` Nelson, Shannon
2025-03-14 5:37 ` Greg Kroah-Hartman
2025-03-14 18:39 ` Leon Romanovsky
2025-03-14 18:09 ` Jacob Keller
2025-03-17 12:33 ` Jason Gunthorpe
2025-03-17 19:00 ` David Ahern
2025-03-17 20:33 ` Keller, Jacob E
2025-03-18 13:20 ` Greg Kroah-Hartman
2025-03-18 13:25 ` Jason Gunthorpe
2025-03-18 15:39 ` Dave Jiang
2025-03-18 16:06 ` Greg Kroah-Hartman
2025-03-19 5:48 ` Przemek Kitszel
2025-03-19 8:14 ` Leon Romanovsky
2025-03-19 10:46 ` Przemek Kitszel
2025-03-19 11:22 ` Leon Romanovsky
2025-03-19 8:17 ` Leon Romanovsky
2025-03-18 22:07 ` Keller, Jacob E
2025-03-06 2:16 ` Jakub Kicinski
2025-03-20 23:22 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306072916.GQ1955273@unreal \
--to=leon@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=aron.silverton@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.jiang@intel.com \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=itayavr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lbloch@nvidia.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).