From: Jason Gunthorpe <jgg@ziepe.ca>
To: longli@linuxonhyperv.com
Cc: Leon Romanovsky <leon@kernel.org>,
Konstantin Taranov <kotaranov@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
Long Li <longli@microsoft.com>
Subject: Re: [patch rdma-next v5 2/2] RDMA/mana_ib: Handle net event for pointing to the current netdev
Date: Thu, 6 Mar 2025 15:53:54 -0400 [thread overview]
Message-ID: <20250306195354.GG354403@ziepe.ca> (raw)
In-Reply-To: <1741289079-18744-2-git-send-email-longli@linuxonhyperv.com>
On Thu, Mar 06, 2025 at 11:24:39AM -0800, longli@linuxonhyperv.com wrote:
> + switch (event) {
> + case NETDEV_CHANGEUPPER:
> + ndev = mana_get_primary_netdev(mc, 0, &dev->dev_tracker);
> + /*
> + * RDMA core will setup GID based on updated netdev.
> + * It's not possible to race with the core as rtnl lock is being
> + * held.
> + */
> + ib_device_set_netdev(&dev->ib_dev, ndev, 1);
> +
> + /* mana_get_primary_netdev() returns ndev with refcount held */
> + netdev_put(ndev, &dev->dev_tracker);
? What is the point of a tracker in dev if it never lasts outside this
scope?
ib_device_set_netdev() already has a tracker built into it.
Jason
next prev parent reply other threads:[~2025-03-06 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 19:24 [patch rdma-next v5 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu longli
2025-03-06 19:24 ` [patch rdma-next v5 2/2] RDMA/mana_ib: Handle net event for pointing to the current netdev longli
2025-03-06 19:53 ` Jason Gunthorpe [this message]
2025-03-06 20:01 ` [EXTERNAL] " Long Li
2025-03-10 21:46 ` Long Li
2025-03-12 13:38 ` Leon Romanovsky
2025-03-12 23:16 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306195354.GG354403@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).