* [PATCH net-next] net/mlx5: Avoid unnecessary use of comma operator
@ 2025-03-07 12:39 Simon Horman
2025-03-07 12:53 ` Michal Swiatkowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Simon Horman @ 2025-03-07 12:39 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Tariq Toukan
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Nathan Chancellor, Nick Desaulniers, Bill Wendling,
Justin Stitt, netdev, linux-rdma, llvm
Although it does not seem to have any untoward side-effects,
the use of ';' to separate to assignments seems more appropriate than ','.
Flagged by clang-19 -Wcomma
No functional change intended.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
index c862dd28c466..e8cc91a9bd82 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
@@ -700,7 +700,7 @@ mlx5_chains_create_global_table(struct mlx5_fs_chains *chains)
goto err_ignore;
}
- chain = mlx5_chains_get_chain_range(chains),
+ chain = mlx5_chains_get_chain_range(chains);
prio = mlx5_chains_get_prio_range(chains);
level = mlx5_chains_get_level_range(chains);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5: Avoid unnecessary use of comma operator
2025-03-07 12:39 [PATCH net-next] net/mlx5: Avoid unnecessary use of comma operator Simon Horman
@ 2025-03-07 12:53 ` Michal Swiatkowski
2025-03-09 11:43 ` Tariq Toukan
2025-03-12 20:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Michal Swiatkowski @ 2025-03-07 12:53 UTC (permalink / raw)
To: Simon Horman
Cc: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
netdev, linux-rdma, llvm
On Fri, Mar 07, 2025 at 12:39:33PM +0000, Simon Horman wrote:
> Although it does not seem to have any untoward side-effects,
> the use of ';' to separate to assignments seems more appropriate than ','.
>
> Flagged by clang-19 -Wcomma
>
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> index c862dd28c466..e8cc91a9bd82 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> @@ -700,7 +700,7 @@ mlx5_chains_create_global_table(struct mlx5_fs_chains *chains)
> goto err_ignore;
> }
>
> - chain = mlx5_chains_get_chain_range(chains),
> + chain = mlx5_chains_get_chain_range(chains);
> prio = mlx5_chains_get_prio_range(chains);
> level = mlx5_chains_get_level_range(chains);
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5: Avoid unnecessary use of comma operator
2025-03-07 12:39 [PATCH net-next] net/mlx5: Avoid unnecessary use of comma operator Simon Horman
2025-03-07 12:53 ` Michal Swiatkowski
@ 2025-03-09 11:43 ` Tariq Toukan
2025-03-12 20:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Tariq Toukan @ 2025-03-09 11:43 UTC (permalink / raw)
To: Simon Horman, Saeed Mahameed, Leon Romanovsky, Tariq Toukan
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Nathan Chancellor, Nick Desaulniers, Bill Wendling,
Justin Stitt, netdev, linux-rdma, llvm
On 07/03/2025 14:39, Simon Horman wrote:
> Although it does not seem to have any untoward side-effects,
> the use of ';' to separate to assignments seems more appropriate than ','.
>
> Flagged by clang-19 -Wcomma
>
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> index c862dd28c466..e8cc91a9bd82 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
> @@ -700,7 +700,7 @@ mlx5_chains_create_global_table(struct mlx5_fs_chains *chains)
> goto err_ignore;
> }
>
> - chain = mlx5_chains_get_chain_range(chains),
> + chain = mlx5_chains_get_chain_range(chains);
> prio = mlx5_chains_get_prio_range(chains);
> level = mlx5_chains_get_level_range(chains);
>
>
>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5: Avoid unnecessary use of comma operator
2025-03-07 12:39 [PATCH net-next] net/mlx5: Avoid unnecessary use of comma operator Simon Horman
2025-03-07 12:53 ` Michal Swiatkowski
2025-03-09 11:43 ` Tariq Toukan
@ 2025-03-12 20:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-03-12 20:40 UTC (permalink / raw)
To: Simon Horman
Cc: saeedm, leon, tariqt, andrew+netdev, davem, edumazet, kuba,
pabeni, nathan, nick.desaulniers+lkml, morbo, justinstitt, netdev,
linux-rdma, llvm
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 07 Mar 2025 12:39:33 +0000 you wrote:
> Although it does not seem to have any untoward side-effects,
> the use of ';' to separate to assignments seems more appropriate than ','.
>
> Flagged by clang-19 -Wcomma
>
> No functional change intended.
> Compile tested only.
>
> [...]
Here is the summary with links:
- [net-next] net/mlx5: Avoid unnecessary use of comma operator
https://git.kernel.org/netdev/net-next/c/17fef2042338
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-12 20:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-07 12:39 [PATCH net-next] net/mlx5: Avoid unnecessary use of comma operator Simon Horman
2025-03-07 12:53 ` Michal Swiatkowski
2025-03-09 11:43 ` Tariq Toukan
2025-03-12 20:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).