netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jonathan Corbet <corbet@lwn.net>,
	 Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	 Jason Wang <jasowang@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	 Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Shuah Khan <shuah@kernel.org>,
	 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	 netdev@vger.kernel.org, kvm@vger.kernel.org,
	 virtualization@lists.linux-foundation.org,
	linux-kselftest@vger.kernel.org,
	 Yuri Benditovich <yuri.benditovich@daynix.com>,
	 Andrew Melnychenko <andrew@daynix.com>,
	 Stephen Hemminger <stephen@networkplumber.org>,
	gur.stavi@huawei.com,  Lei Yang <leiyang@redhat.com>,
	Simon Horman <horms@kernel.org>,
	 Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH net-next v9 4/6] selftest: tun: Test vnet ioctls without device
Date: Fri, 07 Mar 2025 20:01:20 +0900	[thread overview]
Message-ID: <20250307-rss-v9-4-df76624025eb@daynix.com> (raw)
In-Reply-To: <20250307-rss-v9-0-df76624025eb@daynix.com>

Ensure that vnet ioctls result in EBADFD when the underlying device is
deleted.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Lei Yang <leiyang@redhat.com>
---
 tools/testing/selftests/net/tun.c | 74 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/tools/testing/selftests/net/tun.c b/tools/testing/selftests/net/tun.c
index fa83918b62d1be1c93adcd6c2f07654893cf97f8..463dd98f2b80b1bdcb398cee43c834e7dc5cf784 100644
--- a/tools/testing/selftests/net/tun.c
+++ b/tools/testing/selftests/net/tun.c
@@ -159,4 +159,78 @@ TEST_F(tun, reattach_close_delete) {
 	EXPECT_EQ(tun_delete(self->ifname), 0);
 }
 
+FIXTURE(tun_deleted)
+{
+	char ifname[IFNAMSIZ];
+	int fd;
+};
+
+FIXTURE_SETUP(tun_deleted)
+{
+	self->ifname[0] = 0;
+	self->fd = tun_alloc(self->ifname);
+	ASSERT_LE(0, self->fd);
+
+	ASSERT_EQ(0, tun_delete(self->ifname))
+		EXPECT_EQ(0, close(self->fd));
+}
+
+FIXTURE_TEARDOWN(tun_deleted)
+{
+	EXPECT_EQ(0, close(self->fd));
+}
+
+TEST_F(tun_deleted, getvnethdrsz)
+{
+	ASSERT_EQ(-1, ioctl(self->fd, TUNGETVNETHDRSZ));
+	EXPECT_EQ(EBADFD, errno);
+}
+
+TEST_F(tun_deleted, setvnethdrsz)
+{
+	ASSERT_EQ(-1, ioctl(self->fd, TUNSETVNETHDRSZ));
+	EXPECT_EQ(EBADFD, errno);
+}
+
+TEST_F(tun_deleted, getvnetle)
+{
+	ASSERT_EQ(-1, ioctl(self->fd, TUNGETVNETLE));
+	EXPECT_EQ(EBADFD, errno);
+}
+
+TEST_F(tun_deleted, setvnetle)
+{
+	ASSERT_EQ(-1, ioctl(self->fd, TUNSETVNETLE));
+	EXPECT_EQ(EBADFD, errno);
+}
+
+TEST_F(tun_deleted, getvnetbe)
+{
+	ASSERT_EQ(-1, ioctl(self->fd, TUNGETVNETBE));
+	EXPECT_EQ(EBADFD, errno);
+}
+
+TEST_F(tun_deleted, setvnetbe)
+{
+	ASSERT_EQ(-1, ioctl(self->fd, TUNSETVNETBE));
+	EXPECT_EQ(EBADFD, errno);
+}
+
+TEST_F(tun_deleted, getvnethashcap)
+{
+	struct tun_vnet_hash cap;
+	int i = ioctl(self->fd, TUNGETVNETHASHCAP, &cap);
+
+	if (i == -1 && errno == EBADFD)
+		SKIP(return, "TUNGETVNETHASHCAP not supported");
+
+	EXPECT_EQ(0, i);
+}
+
+TEST_F(tun_deleted, setvnethash)
+{
+	ASSERT_EQ(-1, ioctl(self->fd, TUNSETVNETHASH));
+	EXPECT_EQ(EBADFD, errno);
+}
+
 TEST_HARNESS_MAIN

-- 
2.48.1


  parent reply	other threads:[~2025-03-07 11:01 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 11:01 [PATCH net-next v9 0/6] tun: Introduce virtio-net hashing feature Akihiko Odaki
2025-03-07 11:01 ` [PATCH net-next v9 1/6] virtio_net: Add functions for hashing Akihiko Odaki
2025-03-10  3:55   ` Jason Wang
2025-03-10  6:53     ` Akihiko Odaki
2025-03-11  0:47       ` Jason Wang
2025-03-11  5:49         ` Akihiko Odaki
2025-03-17  1:24           ` Jason Wang
2025-03-17  6:08             ` Akihiko Odaki
2025-03-07 11:01 ` [PATCH net-next v9 2/6] net: flow_dissector: Export flow_keys_dissector_symmetric Akihiko Odaki
2025-03-07 11:01 ` [PATCH net-next v9 3/6] tun: Introduce virtio-net hash feature Akihiko Odaki
2025-03-08 19:32   ` Willem de Bruijn
2025-03-10  7:11     ` Akihiko Odaki
2025-03-10  3:55   ` Jason Wang
2025-03-10  4:01     ` Jason Wang
2025-03-10  8:16       ` Akihiko Odaki
2025-03-10  7:45     ` Akihiko Odaki
2025-03-11  0:38       ` Jason Wang
2025-03-11  6:11         ` Akihiko Odaki
2025-03-12  2:35           ` Jason Wang
2025-03-12  5:03             ` Akihiko Odaki
2025-03-17  1:12               ` Jason Wang
2025-03-17  7:06                 ` Akihiko Odaki
2025-03-18  0:15                   ` Jason Wang
2025-03-18 10:10                     ` Akihiko Odaki
2025-03-19  0:58                       ` Jason Wang
2025-03-19  5:28                         ` Akihiko Odaki
2025-03-20  1:31                           ` Jason Wang
2025-03-20  5:33                             ` Akihiko Odaki
2025-03-21  1:13                               ` Jason Wang
2025-03-21  5:56                                 ` Akihiko Odaki
2025-03-24  4:40                                   ` Jason Wang
2025-03-29  9:15                                     ` Akihiko Odaki
2025-03-11  6:17         ` Akihiko Odaki
2025-03-12  2:59           ` Jason Wang
2025-03-12  5:55             ` Akihiko Odaki
2025-03-17  1:15               ` Jason Wang
2025-03-10  7:58     ` Akihiko Odaki
2025-03-11  0:40       ` Jason Wang
2025-03-10  8:13     ` Akihiko Odaki
2025-03-07 11:01 ` Akihiko Odaki [this message]
2025-03-07 11:01 ` [PATCH net-next v9 5/6] selftest: tun: Add tests for virtio-net hashing Akihiko Odaki
2025-03-08 19:39   ` Willem de Bruijn
2025-03-10  4:03   ` Jason Wang
2025-03-11  6:19     ` Akihiko Odaki
2025-03-07 11:01 ` [PATCH net-next v9 6/6] vhost/net: Support VIRTIO_NET_F_HASH_REPORT Akihiko Odaki
2025-03-10  4:43   ` Jason Wang
2025-03-10  7:04     ` Akihiko Odaki
2025-03-11  0:42       ` Jason Wang
2025-03-11  6:24         ` Akihiko Odaki
2025-03-12  3:36           ` Jason Wang
2025-03-12  5:59             ` Akihiko Odaki
2025-03-17  1:15               ` Jason Wang
2025-03-19  4:43                 ` Akihiko Odaki
2025-03-13  1:15 ` [PATCH net-next v9 0/6] tun: Introduce virtio-net hashing feature Lei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307-rss-v9-4-df76624025eb@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=andrew@daynix.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gur.stavi@huawei.com \
    --cc=horms@kernel.org \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=leiyang@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).