[PATCH net-next] net: airoha: Fix dev->dsa_ptr check in airoha_get_dsa_tag()

[PATCH net-next] net: airoha: Fix dev->dsa_ptr check in airoha_get_dsa_tag()

[Lorenzo Bianconi]

Fix the following warning reported by Smatch static checker in
airoha_get_dsa_tag routine:

drivers/net/ethernet/airoha/airoha_eth.c:1722 airoha_get_dsa_tag()
warn: 'dp' isn't an ERR_PTR

dev->dsa_ptr can't be set to an error pointer, it can just be NULL.
Remove this check since it is already performed in netdev_uses_dsa().

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/netdev/Z8l3E0lGOcrel07C@lore-desk/T/#m54adc113fcdd8c5e6c5f65ffd60d8e8b1d483d90
Fixes: af3cf757d5c9 ("net: airoha: Move DSA tag in DMA descriptor")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/ethernet/airoha/airoha_eth.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
index ff837168845d6cacf97708b8b9462829162407bd..021e64d29183418b669e364985e785615b05ab66 100644
--- a/drivers/net/ethernet/airoha/airoha_eth.c
+++ b/drivers/net/ethernet/airoha/airoha_eth.c
@@ -1711,18 +1711,13 @@ static u32 airoha_get_dsa_tag(struct sk_buff *skb, struct net_device *dev)
 {
 #if IS_ENABLED(CONFIG_NET_DSA)
 	struct ethhdr *ehdr;
-	struct dsa_port *dp;
 	u8 xmit_tpid;
 	u16 tag;
 
 	if (!netdev_uses_dsa(dev))
 		return 0;
 
-	dp = dev->dsa_ptr;
-	if (IS_ERR(dp))
-		return 0;
-
-	if (dp->tag_ops->proto != DSA_TAG_PROTO_MTK)
+	if (dev->dsa_ptr->tag_ops->proto != DSA_TAG_PROTO_MTK)
 		return 0;
 
 	if (skb_cow_head(skb, 0))

---
base-commit: f130a0cc1b4ff1ef28a307428d40436032e2b66e
change-id: 20250306-airoha-flowtable-fixes-a91e12770df8

Best regards,
-- 
Lorenzo Bianconi <lorenzo@kernel.org>

Re: [PATCH net-next] net: airoha: Fix dev->dsa_ptr check in airoha_get_dsa_tag()

[Simon Horman]

On Thu, Mar 06, 2025 at 11:52:20AM +0100, Lorenzo Bianconi wrote:
> Fix the following warning reported by Smatch static checker in
> airoha_get_dsa_tag routine:
> 
> drivers/net/ethernet/airoha/airoha_eth.c:1722 airoha_get_dsa_tag()
> warn: 'dp' isn't an ERR_PTR
> 
> dev->dsa_ptr can't be set to an error pointer, it can just be NULL.
> Remove this check since it is already performed in netdev_uses_dsa().
> 
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/netdev/Z8l3E0lGOcrel07C@lore-desk/T/#m54adc113fcdd8c5e6c5f65ffd60d8e8b1d483d90
> Fixes: af3cf757d5c9 ("net: airoha: Move DSA tag in DMA descriptor")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] net: airoha: Fix dev->dsa_ptr check in airoha_get_dsa_tag()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 06 Mar 2025 11:52:20 +0100 you wrote:
> Fix the following warning reported by Smatch static checker in
> airoha_get_dsa_tag routine:
> 
> drivers/net/ethernet/airoha/airoha_eth.c:1722 airoha_get_dsa_tag()
> warn: 'dp' isn't an ERR_PTR
> 
> dev->dsa_ptr can't be set to an error pointer, it can just be NULL.
> Remove this check since it is already performed in netdev_uses_dsa().
> 
> [...]

Here is the summary with links:
  - [net-next] net: airoha: Fix dev->dsa_ptr check in airoha_get_dsa_tag()
    https://git.kernel.org/netdev/net-next/c/e368d2a1e8b6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html