From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C5B014A0A8; Sat, 8 Mar 2025 02:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741402744; cv=none; b=WwsL7/lzfE4VC0iAkNJp0gITMv1LUkAryF9m+MC9tWYahY2k76NHn0CazujDE/6VZTrkEAGRMyELBEhgnyfQatgMTE3mtABbpAjcJmF8v94M7FwVhVIy0unCAUI1McpKe3km7H4/FSvei0Ey3ncPERWElzynU4yzMFvWmOVgpTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741402744; c=relaxed/simple; bh=VpVgfZqL5pCD8VMIpfO//WgO/NgRuraRLNPhr0ucINg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jdsCFdGH5Bpz1feYBVEygphUoUireUTX9+AtDVMym7ARmNxk6hkPcRRXx5xjSqxf0V/LB9C5i3hpR3JhKUXm5NtDagzO+3ksR/1VJilY6r1Dfm2b8a0Qp33i92oDC468e+EX8r1Nw47MhrppfDy00VQR/Uk6+v8tGX/w0p85Ts4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qhLr56rB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qhLr56rB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8FD8C4CED1; Sat, 8 Mar 2025 02:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741402743; bh=VpVgfZqL5pCD8VMIpfO//WgO/NgRuraRLNPhr0ucINg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qhLr56rB5CiqISw9E8FY/8/pkE4H1Kap65yRwfrQjaXE4GKKw5lv7TVmR7y+ppdkm FgOanKxGp4MTHSc8nfMzxrj6FLlgMjFc2zmOP5u6k77tZ36jQXVlHuH0+kNKbrZLfC FJR8HNf8CAITOfIhUkXaq0mew8fo9S9YWEYHqZ4CeqJTprTWbcrDJeaSJRM59zgk/r vIxYIJEmmRa6q2zdHVf3YHpw13tHVbdXOlBEasZOTRC/Tk1IvrpbCaT3ivLydXsyzR R5ZfprFRxepAtpOL/2gAobeDmgCHGOoi8aO1hfPbExbp2yxoKEPpLUF6reTwcbK5HC /ozmbhctbWRPA== Date: Fri, 7 Mar 2025 18:59:02 -0800 From: Jakub Kicinski To: Wei Fang Cc: Claudiu Manoil , Vladimir Oltean , Clark Wang , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "christophe.leroy@csgroup.eu" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP Message-ID: <20250307185902.384554a5@kernel.org> In-Reply-To: References: <20250304072201.1332603-1-wei.fang@nxp.com> <20250304072201.1332603-2-wei.fang@nxp.com> <20250306142842.476db52c@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 8 Mar 2025 02:05:35 +0000 Wei Fang wrote: > > > On Tue, 4 Mar 2025 15:21:49 +0800 Wei Fang wrote: > > hm..., there are some interfaces of netc-lib are used in common .c files > > in downstream, so I used "ifdef" in downstream. Now for the upstream, > > I'm going to separate them from the common .c files. So yes, we can > > remove it now. > > Sorry, I misread the header file. The ifdef in ntmp.h is needed because > the interfaces in this header file will be used by the enetc-core and > enetc-vf drivers. For the ENETC v1 (LS1028A platform), it will not select > NXP_NETC_LIB. Meaning FSL_ENETC ? And the calls are in FSL_ENETC_CORE ?