From: Jason Gunthorpe <jgg@nvidia.com>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: andrew.gospodarek@broadcom.com, aron.silverton@oracle.com,
dan.j.williams@intel.com, daniel.vetter@ffwll.ch,
dave.jiang@intel.com, dsahern@kernel.org,
gregkh@linuxfoundation.org, hch@infradead.org,
itayavr@nvidia.com, jiri@nvidia.com, Jonathan.Cameron@huawei.com,
kuba@kernel.org, lbloch@nvidia.com, leonro@nvidia.com,
linux-cxl@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, saeedm@nvidia.com, brett.creeley@amd.com
Subject: Re: [PATCH v3 5/6] pds_fwctl: add rpc and query support
Date: Fri, 7 Mar 2025 19:38:11 -0400 [thread overview]
Message-ID: <20250307233811.GZ354511@nvidia.com> (raw)
In-Reply-To: <20250307185329.35034-6-shannon.nelson@amd.com>
On Fri, Mar 07, 2025 at 10:53:28AM -0800, Shannon Nelson wrote:
> +#define PDS_FWCTL_RPC_OPCODE_GET_CMD(op) FIELD_GET(PDS_FWCTL_RPC_OPCODE_CMD_MASK, op)
> +#define PDS_FWCTL_RPC_OPCODE_GET_VER(op) FIELD_GET(PDS_FWCTL_RPC_OPCODE_VER_MASK, op)
../drivers/fwctl/pds/main.c:302:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
302 | if (PDS_FWCTL_RPC_OPCODE_CMP(rpc->in.op, op_entry[i].id)) {
Add:
#include <linux/bitfield.h>
Jason
next prev parent reply other threads:[~2025-03-07 23:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 18:53 [PATCH v3 0/6] pds_fwctl: fwctl for AMD/Pensando core devices Shannon Nelson
2025-03-07 18:53 ` [PATCH v3 1/6] pds_core: make pdsc_auxbus_dev_del() void Shannon Nelson
2025-03-10 16:58 ` Dave Jiang
2025-03-07 18:53 ` [PATCH v3 2/6] pds_core: specify auxiliary_device to be created Shannon Nelson
2025-03-10 17:26 ` Dave Jiang
2025-03-17 22:30 ` Nelson, Shannon
2025-03-07 18:53 ` [PATCH v3 3/6] pds_core: add new fwctl auxiliary_device Shannon Nelson
2025-03-10 17:33 ` Dave Jiang
2025-03-17 22:37 ` Nelson, Shannon
2025-03-12 18:22 ` Jonathan Cameron
2025-03-07 18:53 ` [PATCH v3 4/6] pds_fwctl: initial driver framework Shannon Nelson
2025-03-10 18:28 ` Dave Jiang
2025-03-17 22:40 ` Nelson, Shannon
2025-03-12 18:25 ` Jonathan Cameron
2025-03-07 18:53 ` [PATCH v3 5/6] pds_fwctl: add rpc and query support Shannon Nelson
2025-03-07 23:38 ` Jason Gunthorpe [this message]
2025-03-17 22:24 ` Nelson, Shannon
2025-03-12 18:29 ` Jonathan Cameron
2025-03-07 18:53 ` [PATCH v3 6/6] pds_fwctl: add Documentation entries Shannon Nelson
2025-03-10 20:27 ` Dave Jiang
2025-03-17 22:41 ` Nelson, Shannon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307233811.GZ354511@nvidia.com \
--to=jgg@nvidia.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=aron.silverton@oracle.com \
--cc=brett.creeley@amd.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.jiang@intel.com \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=itayavr@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=lbloch@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).