From: Jakub Kicinski <kuba@kernel.org>
To: Kohei Enju <enjuk@amazon.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bpf@vger.kernel.org>, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"Ahmed Zaki" <ahmed.zaki@intel.com>,
Stanislav Fomichev <sdf@fomichev.me>,
"Alexander Lobakin" <aleksander.lobakin@intel.com>,
Kohei Enju <kohei.enju@gmail.com>
Subject: Re: [PATCH net-next v1] dev: remove netdev_lock() and netdev_lock_ops() in register_netdevice().
Date: Sat, 8 Mar 2025 13:18:13 -0800 [thread overview]
Message-ID: <20250308131813.4f8c8f0d@kernel.org> (raw)
In-Reply-To: <20250308203835.60633-2-enjuk@amazon.com>
On Sun, 9 Mar 2025 05:37:18 +0900 Kohei Enju wrote:
> Both netdev_lock() and netdev_lock_ops() are called before
> list_netdevice() in register_netdevice().
> No other context can access the struct net_device, so we don't need these
> locks in this context.
Doesn't sysfs get registered earlier?
I'm afraid not being able to take the lock from the registration
path ties our hands too much. Maybe we need to make a more serious
attempt at letting the caller take the lock?
next prev parent reply other threads:[~2025-03-08 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 20:37 [PATCH net-next v1] dev: remove netdev_lock() and netdev_lock_ops() in register_netdevice() Kohei Enju
2025-03-08 21:18 ` Jakub Kicinski [this message]
2025-03-08 22:41 ` Stanislav Fomichev
2025-03-09 21:41 ` Stanislav Fomichev
2025-03-08 22:41 ` Jakub Kicinski
2025-03-08 22:59 ` Stanislav Fomichev
2025-03-08 23:51 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250308131813.4f8c8f0d@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enjuk@amazon.com \
--cc=horms@kernel.org \
--cc=kohei.enju@gmail.com \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).