[PATCH net-next v1 1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()

[PATCH net-next v1 1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()

[Choong Yong Liang]

Fix the warning "warn: missing error code? 'ret'" in the
intel_tsn_lane_is_available() function.

The function now returns 0 to indicate that a TSN lane was found and
returns -EINVAL when it is not found.

Fixes: a42f6b3f1cc1 ("net: stmmac: configure SerDes according to the interface mode")
Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
index 9c8de47ee149..5910571a954f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
@@ -494,10 +494,10 @@ static int intel_tsn_lane_is_available(struct net_device *ndev,
 			if ((rbuf.buf[0] >>
 				(4 * (intel_priv->tsn_lane_regs[j] % 8)) &
 					B_PCH_FIA_PCR_L0O) == 0xB)
-				return ret;
+				return 0;
 	}
 
-	return ret;
+	return -EINVAL;
 }
 
 static int intel_set_reg_access(const struct pmc_serdes_regs *regs, int max_regs)
-- 
2.34.1

Re: [PATCH net-next v1 1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()

[Kory Maincent]

On Mon, 10 Mar 2025 13:08:35 +0800
Choong Yong Liang <yong.liang.choong@linux.intel.com> wrote:

> Fix the warning "warn: missing error code? 'ret'" in the
> intel_tsn_lane_is_available() function.
> 
> The function now returns 0 to indicate that a TSN lane was found and
> returns -EINVAL when it is not found.
> 
> Fixes: a42f6b3f1cc1 ("net: stmmac: configure SerDes according to the
> interface mode")
> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>

This patch is a fix it should go net instead net-next.
Could you resend the patch with net prefix?

Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>

Thank you!
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next v1 1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()

[Choong Yong Liang]

On 10/3/2025 10:20 pm, Kory Maincent wrote:
> On Mon, 10 Mar 2025 13:08:35 +0800
> Choong Yong Liang <yong.liang.choong@linux.intel.com> wrote:
> 
>> Fix the warning "warn: missing error code? 'ret'" in the
>> intel_tsn_lane_is_available() function.
>>
>> The function now returns 0 to indicate that a TSN lane was found and
>> returns -EINVAL when it is not found.
>>
>> Fixes: a42f6b3f1cc1 ("net: stmmac: configure SerDes according to the
>> interface mode")
>> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
> 
> This patch is a fix it should go net instead net-next.
> Could you resend the patch with net prefix?
> 
> Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
> 
> Thank you!

Hi Kory,

Thank you for your feedback. I understand that the patch is a fix. However, 
since the code is not yet in the 'net' tree, we are unable to apply the fix 
there.

I'm not sure if there is another way to handle this fix other than sending 
it to the 'net-next' tree. I would appreciate any guidance you might have 
on this matter.

Re: [PATCH net-next v1 1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()

[Kory Maincent]

On Tue, 11 Mar 2025 13:33:42 +0800
Choong Yong Liang <yong.liang.choong@linux.intel.com> wrote:

> On 10/3/2025 10:20 pm, Kory Maincent wrote:
> > On Mon, 10 Mar 2025 13:08:35 +0800
> > Choong Yong Liang <yong.liang.choong@linux.intel.com> wrote:
> >   
> >> Fix the warning "warn: missing error code? 'ret'" in the
> >> intel_tsn_lane_is_available() function.
> >>
> >> The function now returns 0 to indicate that a TSN lane was found and
> >> returns -EINVAL when it is not found.
> >>
> >> Fixes: a42f6b3f1cc1 ("net: stmmac: configure SerDes according to the
> >> interface mode")
> >> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>  
> > 
> > This patch is a fix it should go net instead net-next.
> > Could you resend the patch with net prefix?
> > 
> > Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
> > 
> > Thank you!  
> 
> Hi Kory,
> 
> Thank you for your feedback. I understand that the patch is a fix. However, 
> since the code is not yet in the 'net' tree, we are unable to apply the fix 
> there.
> 
> I'm not sure if there is another way to handle this fix other than sending 
> it to the 'net-next' tree. I would appreciate any guidance you might have 
> on this matter.

Oh, my bad! In that case you are right to send it to net-next. Sorry for the
noise.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next v1 1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()

[Simon Horman]

On Mon, Mar 10, 2025 at 01:08:35PM +0800, Choong Yong Liang wrote:
> Fix the warning "warn: missing error code? 'ret'" in the
> intel_tsn_lane_is_available() function.
> 
> The function now returns 0 to indicate that a TSN lane was found and
> returns -EINVAL when it is not found.
> 
> Fixes: a42f6b3f1cc1 ("net: stmmac: configure SerDes according to the interface mode")
> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next v1 1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Mon, 10 Mar 2025 13:08:35 +0800 you wrote:
> Fix the warning "warn: missing error code? 'ret'" in the
> intel_tsn_lane_is_available() function.
> 
> The function now returns 0 to indicate that a TSN lane was found and
> returns -EINVAL when it is not found.
> 
> Fixes: a42f6b3f1cc1 ("net: stmmac: configure SerDes according to the interface mode")
> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v1,1/1] stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()
    https://git.kernel.org/netdev/net-next/c/38f13bf80130

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html