Re: [PATCH v6 02/10] property: Add functions to iterate named child

Matti Vaittinen
2025-03-13T06:42:24Z

Hi Andy,

Thanks for the review.

On 10/03/2025 16:25, Andy Shevchenko wrote:
> On Mon, Mar 10, 2025 at 02:55:53PM +0200, Matti Vaittinen wrote:

...

>> +#define fwnode_for_each_named_child_node(fwnode, child, name) \
>> + fwnode_for_each_child_node(fwnode, child) \
>
> One TAB too much.
>
>> + if (!fwnode_name_eq(child, name)) { } else
>
> Ditto.
>
> Note, I believe this won't get v6.15-rc1, so there will be for_each_if()
> available and these will become

I'll use for_each_if() if I'll have to rebase this to the v6.15-rc1.

> But see above the proposed additional patch that you may include in your next
> version.

Seems like you sent it as it's own series. I believe it's better that way.

Yours,
-- Matti