netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Kalle Valo <kvalo@kernel.org>,
	Julia Lawall <Julia.Lawall@inria.fr>,
	En-Wei Wu <en-wei.wu@canonical.com>,
	Shaul Triebitz <shaul.triebitz@intel.com>,
	Alexander Wetzel <alexander@wetzel-home.de>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	Miri Korenblit <miriam.rachel.korenblit@intel.com>,
	linux-kernel@vger.kernel.org,
	syzbot+d6eb9cee2885ec06f5e3@syzkaller.appspotmail.com,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] wifi: mac80211: Add __nonstring annotations for unterminated strings
Date: Tue, 11 Mar 2025 15:36:42 -0700	[thread overview]
Message-ID: <202503111530.43283E3@keescook> (raw)
In-Reply-To: <12b44f58b339aa92f1b17fb7b33e30a920aad86c.camel@sipsolutions.net>

On Tue, Mar 11, 2025 at 10:25:10AM +0100, Johannes Berg wrote:
> On Mon, 2025-03-10 at 15:23 -0700, Kees Cook wrote:
> > 
> >  drivers/net/wireless/virtual/virt_wifi.c     | 2 +-
> >  drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +-
> > 
> 
> That's not mac80211?

Hrm, you're right. The automation I use for splitting up "treewide"
changes per subsystem tries to guess at a reasonable subject give a set
of files, based on historical git subject prefixes. And these two files
ended up grouped together because no more specific subsystem claimed
them.

It seems I should probably split this into two, as:

wifi: zd1211rw:
wifi: virt_wifi:

> Also, I have no idea how you came up with the CC list but it seems
> excessive. :)

It's based on my permutation of arguments to get_maintainers.pl that
seems to work best for splitting my "treewide" changes per subsystem:

        ccs = subprocess.run(["./scripts/get_maintainer.pl", "--email",
                              "--git-min-percent", "15",
                              "--git-since", '3-years-ago',
                              "--no-rolestats", patch.name],

-Kees

-- 
Kees Cook

      reply	other threads:[~2025-03-11 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 22:23 [PATCH] wifi: mac80211: Add __nonstring annotations for unterminated strings Kees Cook
2025-03-11  9:25 ` Johannes Berg
2025-03-11 22:36   ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202503111530.43283E3@keescook \
    --to=kees@kernel.org \
    --cc=Julia.Lawall@inria.fr \
    --cc=alexander@wetzel-home.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=en-wei.wu@canonical.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shaul.triebitz@intel.com \
    --cc=syzbot+d6eb9cee2885ec06f5e3@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).