From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: netdev@vger.kernel.org
Cc: jiri@resnulli.us, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
pierre@stackhpc.com, hkallweit1@gmail.com, linux@armlinux.org.uk,
maxime.chevallier@bootlin.com, christophe.leroy@csgroup.eu,
arkadiusz.kubalewski@intel.com, vadim.fedorenko@linux.dev,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: [PATCH net v2 3/3] phy: fix xa_alloc_cyclic() error handling
Date: Wed, 12 Mar 2025 10:52:51 +0100 [thread overview]
Message-ID: <20250312095251.2554708-4-michal.swiatkowski@linux.intel.com> (raw)
In-Reply-To: <20250312095251.2554708-1-michal.swiatkowski@linux.intel.com>
xa_alloc_cyclic() can return 1, which isn't an error. To prevent
situation when the caller of this function will treat it as no error do
a check only for negative here.
Fixes: 384968786909 ("net: phy: Introduce ethernet link topology representation")
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
---
drivers/net/phy/phy_link_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy_link_topology.c b/drivers/net/phy/phy_link_topology.c
index 4a5d73002a1a..0e9e987f37dd 100644
--- a/drivers/net/phy/phy_link_topology.c
+++ b/drivers/net/phy/phy_link_topology.c
@@ -73,7 +73,7 @@ int phy_link_topo_add_phy(struct net_device *dev,
xa_limit_32b, &topo->next_phy_index,
GFP_KERNEL);
- if (ret)
+ if (ret < 0)
goto err;
return 0;
--
2.42.0
next prev parent reply other threads:[~2025-03-12 9:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 9:52 [PATCH net v2 0/3] fix xa_alloc_cyclic() return checks Michal Swiatkowski
2025-03-12 9:52 ` [PATCH net v2 1/3] devlink: fix xa_alloc_cyclic() error handling Michal Swiatkowski
2025-03-12 13:15 ` Andrew Lunn
2025-03-14 13:33 ` Jiri Pirko
2025-03-12 9:52 ` [PATCH net v2 2/3] dpll: " Michal Swiatkowski
2025-03-12 10:33 ` Vadim Fedorenko
2025-03-12 10:55 ` Kubalewski, Arkadiusz
2025-03-14 13:33 ` Jiri Pirko
2025-03-12 9:52 ` Michal Swiatkowski [this message]
2025-03-12 11:35 ` [PATCH net v2 3/3] phy: " Maxime Chevallier
2025-03-14 10:23 ` [PATCH net v2 0/3] fix xa_alloc_cyclic() return checks Dan Carpenter
2025-03-14 12:52 ` Przemek Kitszel
2025-03-14 14:13 ` Dan Carpenter
2025-03-14 14:23 ` Matthew Wilcox
2025-03-17 8:55 ` Przemek Kitszel
2025-03-17 12:24 ` Matthew Wilcox
2025-03-19 8:45 ` Przemek Kitszel
2025-03-19 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312095251.2554708-4-michal.swiatkowski@linux.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pierre@stackhpc.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).