Re: [PATCH net-next v3 1/3] dt-bindings: net: dwmac: Increase 'maxItems' for 'interrupts' and 'interrupt-names'

[Rob Herring <robh@kernel.org>]

On Tue, Mar 11, 2025 at 10:17:28PM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Increase the `maxItems` value for the `interrupts` and `interrupt-names`
> properties to 11 to support additional per-channel Tx/Rx completion
> interrupts on the Renesas RZ/V2H(P) SoC, which features the
> `snps,dwmac-5.20` IP.
> 
> Refactor the `interrupt-names` property by replacing repeated `enum`
> entries with a `oneOf` list. Add support for per-channel receive and
> transmit completion interrupts using regex patterns.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Note, for adding constraints to vendor bindings patch [0] has been sent
> out seprately.
> 
> [0] https://lore.kernel.org/all/20250309003301.1152228-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
> 
> v2->v3
> - Dropped adding `additionalItems`
> - Moved interrupts description into interrupt-names
> - Replaced enum with a oneOf and added Rx/Tx regex patterns
> 
> v1->v2
> - No change
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml   | 24 ++++++++++++-------
>  1 file changed, 15 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 78b3030dc56d..bacec6e6514b 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -114,19 +114,25 @@ properties:
>  
>    interrupts:
>      minItems: 1
> -    items:
> -      - description: Combined signal for various interrupt events
> -      - description: The interrupt to manage the remote wake-up packet detection
> -      - description: The interrupt that occurs when Rx exits the LPI state
> -      - description: The interrupt that occurs when HW safety error triggered
> +    maxItems: 11
>  
>    interrupt-names:
>      minItems: 1
> +    maxItems: 26

Oops! I assume you meant 11. With that fixed:

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

>      items:
> -      - const: macirq
> -      - enum: [eth_wake_irq, eth_lpi, sfty]
> -      - enum: [eth_wake_irq, eth_lpi, sfty]
> -      - enum: [eth_wake_irq, eth_lpi, sfty]
> +      oneOf:
> +        - description: Combined signal for various interrupt events
> +          const: macirq
> +        - description: The interrupt to manage the remote wake-up packet detection
> +          const: eth_wake_irq
> +        - description: The interrupt that occurs when Rx exits the LPI state
> +          const: eth_lpi
> +        - description: The interrupt that occurs when HW safety error triggered
> +          const: sfty
> +        - description: Per channel receive completion interrupt
> +          pattern: '^rx-queue-[0-3]$'
> +        - description: Per channel transmit completion interrupt
> +          pattern: '^tx-queue-[0-3]$'
>  
>    clocks:
>      minItems: 1
> -- 
> 2.43.0
>