From: Simon Horman <horms@kernel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, przemyslaw.kitszel@intel.com,
Jacob Keller <jacob.e.keller@intel.com>,
Bharath R <bharath.r@intel.com>,
Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>,
Piotr Kwapulinski <piotr.kwapulinski@intel.com>,
Stefan Wegrzyn <stefan.wegrzyn@intel.com>
Subject: Re: [PATCH iwl-next v7 11/15] ixgbe: add device flash update via devlink
Date: Wed, 12 Mar 2025 15:55:30 +0100 [thread overview]
Message-ID: <20250312145530.GU4159220@kernel.org> (raw)
In-Reply-To: <20250312125843.347191-12-jedrzej.jagielski@intel.com>
On Wed, Mar 12, 2025 at 01:58:39PM +0100, Jedrzej Jagielski wrote:
...
> diff --git a/Documentation/networking/devlink/ixgbe.rst b/Documentation/networking/devlink/ixgbe.rst
> index a41073a62776..41aedf4b8017 100644
> --- a/Documentation/networking/devlink/ixgbe.rst
> +++ b/Documentation/networking/devlink/ixgbe.rst
> @@ -64,3 +64,27 @@ The ``ixgbe`` driver reports the following versions
> - running
> - 0xee16ced7
> - The first 4 bytes of the hash of the netlist module contents.
> +
> +Flash Update
> +============
> +The ``ixgbe`` driver implements support for flash update using the
> +``devlink-flash`` interface. It supports updating the device flash using a
> +combined flash image that contains the ``fw.mgmt``, ``fw.undi``, and
> +``fw.netlist`` components.
> +.. list-table:: List of supported overwrite modes
> + :widths: 5 95
Hi Jedrzej,
make htmldocs flags two warnings, which I believe can be resolved by
adding a blank line here.
.../ixgbe.rst:75: ERROR: Unexpected indentation.
.../ixgbe.rst:76: WARNING: Field list ends without a blank line; unexpected unindent.
> + * - Bits
> + - Behavior
> + * - ``DEVLINK_FLASH_OVERWRITE_SETTINGS``
> + - Do not preserve settings stored in the flash components being
> + updated. This includes overwriting the port configuration that
> + determines the number of physical functions the device will
> + initialize with.
> + * - ``DEVLINK_FLASH_OVERWRITE_SETTINGS`` and ``DEVLINK_FLASH_OVERWRITE_IDENTIFIERS``
> + - Do not preserve either settings or identifiers. Overwrite everything
> + in the flash with the contents from the provided image, without
> + performing any preservation. This includes overwriting device
> + identifying fields such as the MAC address, Vital product Data (VPD) area,
> + and device serial number. It is expected that this combination be used with an
> + image customized for the specific device.
> +
...
next prev parent reply other threads:[~2025-03-12 14:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 12:58 [PATCH iwl-next v7 00/15] ixgbe: Add basic devlink support Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 01/15] devlink: add value check to devlink_info_version_put() Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 02/15] ixgbe: wrap netdev_priv() usage Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 03/15] ixgbe: add initial devlink support Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 04/15] ixgbe: add handler for devlink .info_get() Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 05/15] ixgbe: add E610 functions for acquiring flash data Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 06/15] ixgbe: read the OROM version information Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 07/15] ixgbe: read the netlist " Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 08/15] ixgbe: add .info_get() extension specific for E610 devices Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 09/15] ixgbe: add E610 functions getting PBA and FW ver info Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 10/15] ixgbe: extend .info_get with() stored versions Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 11/15] ixgbe: add device flash update via devlink Jedrzej Jagielski
2025-03-12 14:55 ` Simon Horman [this message]
2025-03-13 11:20 ` Jagielski, Jedrzej
2025-03-12 12:58 ` [PATCH iwl-next v7 12/15] ixgbe: add support for devlink reload Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 13/15] ixgbe: add FW API version check Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 14/15] ixgbe: add E610 implementation of FW recovery mode Jedrzej Jagielski
2025-03-12 12:58 ` [PATCH iwl-next v7 15/15] ixgbe: add support for FW rollback mode Jedrzej Jagielski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312145530.GU4159220@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=bharath.r@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotr.kwapulinski@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=slawomirx.mrozowicz@intel.com \
--cc=stefan.wegrzyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).