From: Jakub Kicinski <kuba@kernel.org>
To: Michal Kubiak <michal.kubiak@intel.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>, <sdf@fomichev.me>
Subject: Re: [PATCH net-next] netdevsim: 'support' multi-buf XDP
Date: Wed, 12 Mar 2025 21:42:22 +0100 [thread overview]
Message-ID: <20250312214222.0feb96ec@kernel.org> (raw)
In-Reply-To: <Z9AVs2laMDqYPp6S@localhost.localdomain>
On Tue, 11 Mar 2025 11:51:31 +0100 Michal Kubiak wrote:
> > - if (ns->netdev->mtu > NSIM_XDP_MAX_MTU) {
> > + if (bpf->prog && !bpf->prog->aux->xdp_has_frags &&
> > + ns->netdev->mtu > NSIM_XDP_MAX_MTU) {
> > NSIM_EA(bpf->extack, "MTU too large w/ XDP enabled");
>
> Would it make sense to extend this error message to indicate that single-buf
> XDP is being used? For example: "MTU too large w/ single-buf XDP enabled"?
> (Please consider this as a suggestion only.)
Fair point, tho I'd rather push as is. It fixes the CI and some other
tests match on this exact error message so I'd need to fully retest
the respin..
next prev parent reply other threads:[~2025-03-12 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 9:28 [PATCH net-next] netdevsim: 'support' multi-buf XDP Jakub Kicinski
2025-03-11 10:51 ` Michal Kubiak
2025-03-12 20:42 ` Jakub Kicinski [this message]
2025-03-12 20:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312214222.0feb96ec@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).