From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net, Andrew Lunn <andrew@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Simon Horman" <horms@kernel.org>,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>
Subject: [PATCH net-next v3 2/7] net: ethtool: netlink: Rename ethnl_default_dump_one
Date: Thu, 13 Mar 2025 19:26:41 +0100 [thread overview]
Message-ID: <20250313182647.250007-3-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20250313182647.250007-1-maxime.chevallier@bootlin.com>
As we work on getting more objects out of a per-netdev DUMP, rename
ethnl_default_dump_one() into ethnl_default_dump_one_dev(), making it
explicit that this dumps everything for one netdev.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
net/ethtool/netlink.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
index 7adede5e4ff1..644c202d284d 100644
--- a/net/ethtool/netlink.c
+++ b/net/ethtool/netlink.c
@@ -540,9 +540,9 @@ static int ethnl_default_doit(struct sk_buff *skb, struct genl_info *info)
return ret;
}
-static int ethnl_default_dump_one(struct sk_buff *skb, struct net_device *dev,
- const struct ethnl_dump_ctx *ctx,
- const struct genl_info *info)
+static int ethnl_default_dump_one_dev(struct sk_buff *skb, struct net_device *dev,
+ const struct ethnl_dump_ctx *ctx,
+ const struct genl_info *info)
{
void *ehdr;
int ret;
@@ -593,8 +593,8 @@ static int ethnl_default_dumpit(struct sk_buff *skb,
/* Filtered DUMP request targeted to a single netdev. We already
* hold a ref to the netdev from ->start()
*/
- ret = ethnl_default_dump_one(skb, dev, ctx,
- genl_info_dump(cb));
+ ret = ethnl_default_dump_one_dev(skb, dev, ctx,
+ genl_info_dump(cb));
rcu_read_lock();
netdev_put(ctx->req_info->dev, &ctx->req_info->dev_tracker);
@@ -606,8 +606,8 @@ static int ethnl_default_dumpit(struct sk_buff *skb,
dev_hold(dev);
rcu_read_unlock();
- ret = ethnl_default_dump_one(skb, dev, ctx,
- genl_info_dump(cb));
+ ret = ethnl_default_dump_one_dev(skb, dev, ctx,
+ genl_info_dump(cb));
rcu_read_lock();
dev_put(dev);
--
2.48.1
next prev parent reply other threads:[~2025-03-13 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 18:26 [PATCH net-next v3 0/7] net: ethtool: Introduce ethnl dump helpers Maxime Chevallier
2025-03-13 18:26 ` [PATCH net-next v3 1/7] net: ethtool: netlink: Allow per-netdevice DUMP operations Maxime Chevallier
2025-03-21 16:31 ` Paolo Abeni
2025-03-21 17:41 ` Maxime Chevallier
2025-03-13 18:26 ` Maxime Chevallier [this message]
2025-03-13 18:26 ` [PATCH net-next v3 3/7] net: ethtool: netlink: Introduce command-specific dump_one_dev Maxime Chevallier
2025-03-13 18:26 ` [PATCH net-next v3 4/7] net: ethtool: netlink: Introduce per-phy DUMP helpers Maxime Chevallier
2025-03-13 18:26 ` [PATCH net-next v3 5/7] net: ethtool: phy: Convert the PHY_GET command to generic phy dump Maxime Chevallier
2025-03-13 18:26 ` [PATCH net-next v3 6/7] net: ethtool: plca: Use per-PHY DUMP operations Maxime Chevallier
2025-03-13 18:26 ` [PATCH net-next v3 7/7] net: ethtool: pse-pd: " Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313182647.250007-3-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).