From: pwn9uin@gmail.com
To: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, Minjoong Kim <alswnd4123@outlook.kr>
Subject: [PATCH net] atm: null pointer dereference when both entry and holding_time are NULL.
Date: Fri, 14 Mar 2025 00:34:04 +0000 [thread overview]
Message-ID: <20250314003404.16408-1-pwn9uin@gmail.com> (raw)
From: Minjoong Kim <alswnd4123@outlook.kr>
When MPOA_cache_impos_rcvd() receives the msg, it can trigger
Null Pointer Dereference Vulnerability if both entry and
holding_time are NULL. Because there is only for the situation
where entry is NULL and holding_time exists, it can be passed
when both entry and holding_time are NULL. If these are NULL,
the entry will be passd to eg_cache_put() as parameter and
it is referenced by entry->use code in it.
Signed-off-by: Minjoong Kim <alswnd4123@outlook.kr>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
net/atm/mpc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/atm/mpc.c b/net/atm/mpc.c
index 324e3ab96bb3..7fb854ea47dc 100644
--- a/net/atm/mpc.c
+++ b/net/atm/mpc.c
@@ -1314,6 +1314,9 @@ static void MPOA_cache_impos_rcvd(struct k_message *msg,
holding_time = msg->content.eg_info.holding_time;
dprintk("(%s) entry = %p, holding_time = %u\n",
mpc->dev->name, entry, holding_time);
+ if (entry == NULL && !holding_time) {
+ return;
+ }
if (entry == NULL && holding_time) {
entry = mpc->eg_ops->add_entry(msg, mpc);
mpc->eg_ops->put(entry);
--
2.34.1
next reply other threads:[~2025-03-14 0:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 0:34 pwn9uin [this message]
2025-03-19 12:03 ` [PATCH net] atm: null pointer dereference when both entry and holding_time are NULL Simon Horman
2025-03-20 9:36 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314003404.16408-1-pwn9uin@gmail.com \
--to=pwn9uin@gmail.com \
--cc=alswnd4123@outlook.kr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).