* [PATCH] net: airoha: fix CONFIG_DEBUG_FS check
@ 2025-03-14 15:49 Arnd Bergmann
2025-03-14 19:02 ` Lorenzo Bianconi
2025-03-21 17:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-03-14 15:49 UTC (permalink / raw)
To: Lorenzo Bianconi, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Arnd Bergmann, Simon Horman, Christian Marangi, linux-arm-kernel,
linux-mediatek, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The #if check causes a build failure when CONFIG_DEBUG_FS is turned
off:
In file included from drivers/net/ethernet/airoha/airoha_eth.c:17:
drivers/net/ethernet/airoha/airoha_eth.h:543:5: error: "CONFIG_DEBUG_FS" is not defined, evaluates to 0 [-Werror=undef]
543 | #if CONFIG_DEBUG_FS
| ^~~~~~~~~~~~~~~
Replace it with the correct #ifdef.
Fixes: 3fe15c640f38 ("net: airoha: Introduce PPE debugfs support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/airoha/airoha_eth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/airoha/airoha_eth.h b/drivers/net/ethernet/airoha/airoha_eth.h
index f66b9b736b94..60690b685710 100644
--- a/drivers/net/ethernet/airoha/airoha_eth.h
+++ b/drivers/net/ethernet/airoha/airoha_eth.h
@@ -540,7 +540,7 @@ void airoha_ppe_deinit(struct airoha_eth *eth);
struct airoha_foe_entry *airoha_ppe_foe_get_entry(struct airoha_ppe *ppe,
u32 hash);
-#if CONFIG_DEBUG_FS
+#ifdef CONFIG_DEBUG_FS
int airoha_ppe_debugfs_init(struct airoha_ppe *ppe);
#else
static inline int airoha_ppe_debugfs_init(struct airoha_ppe *ppe)
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: airoha: fix CONFIG_DEBUG_FS check
2025-03-14 15:49 [PATCH] net: airoha: fix CONFIG_DEBUG_FS check Arnd Bergmann
@ 2025-03-14 19:02 ` Lorenzo Bianconi
2025-03-21 17:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2025-03-14 19:02 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Arnd Bergmann, Simon Horman, Christian Marangi,
linux-arm-kernel, linux-mediatek, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]
> From: Arnd Bergmann <arnd@arndb.de>
>
> The #if check causes a build failure when CONFIG_DEBUG_FS is turned
> off:
>
> In file included from drivers/net/ethernet/airoha/airoha_eth.c:17:
> drivers/net/ethernet/airoha/airoha_eth.h:543:5: error: "CONFIG_DEBUG_FS" is not defined, evaluates to 0 [-Werror=undef]
> 543 | #if CONFIG_DEBUG_FS
> | ^~~~~~~~~~~~~~~
>
> Replace it with the correct #ifdef.
>
> Fixes: 3fe15c640f38 ("net: airoha: Introduce PPE debugfs support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/ethernet/airoha/airoha_eth.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/airoha/airoha_eth.h b/drivers/net/ethernet/airoha/airoha_eth.h
> index f66b9b736b94..60690b685710 100644
> --- a/drivers/net/ethernet/airoha/airoha_eth.h
> +++ b/drivers/net/ethernet/airoha/airoha_eth.h
> @@ -540,7 +540,7 @@ void airoha_ppe_deinit(struct airoha_eth *eth);
> struct airoha_foe_entry *airoha_ppe_foe_get_entry(struct airoha_ppe *ppe,
> u32 hash);
>
> -#if CONFIG_DEBUG_FS
> +#ifdef CONFIG_DEBUG_FS
> int airoha_ppe_debugfs_init(struct airoha_ppe *ppe);
> #else
> static inline int airoha_ppe_debugfs_init(struct airoha_ppe *ppe)
> --
> 2.39.5
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: airoha: fix CONFIG_DEBUG_FS check
2025-03-14 15:49 [PATCH] net: airoha: fix CONFIG_DEBUG_FS check Arnd Bergmann
2025-03-14 19:02 ` Lorenzo Bianconi
@ 2025-03-21 17:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-03-21 17:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: lorenzo, andrew+netdev, davem, edumazet, kuba, pabeni, arnd,
horms, ansuelsmth, linux-arm-kernel, linux-mediatek, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 14 Mar 2025 16:49:59 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The #if check causes a build failure when CONFIG_DEBUG_FS is turned
> off:
>
> In file included from drivers/net/ethernet/airoha/airoha_eth.c:17:
> drivers/net/ethernet/airoha/airoha_eth.h:543:5: error: "CONFIG_DEBUG_FS" is not defined, evaluates to 0 [-Werror=undef]
> 543 | #if CONFIG_DEBUG_FS
> | ^~~~~~~~~~~~~~~
>
> [...]
Here is the summary with links:
- net: airoha: fix CONFIG_DEBUG_FS check
https://git.kernel.org/netdev/net-next/c/08d0185e36ad
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-21 17:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-14 15:49 [PATCH] net: airoha: fix CONFIG_DEBUG_FS check Arnd Bergmann
2025-03-14 19:02 ` Lorenzo Bianconi
2025-03-21 17:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).