From: Greg KH <gregkh@linuxfoundation.org>
To: Youngmin Nam <youngmin.nam@samsung.com>
Cc: stable@vger.kernel.org, ncardwell@google.com,
edumazet@google.com, kuba@kernel.org, davem@davemloft.net,
dsahern@kernel.org, pabeni@redhat.com, horms@kernel.org,
guo88.liu@samsung.com, yiwang.cai@samsung.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
joonki.min@samsung.com, hajun.sung@samsung.com,
d7271.choe@samsung.com, sw.ju@samsung.com,
dujeong.lee@samsung.com, ycheng@google.com, yyd@google.com,
kuro@kuroa.me, cmllamas@google.com, willdeacon@google.com,
maennich@google.com, gregkh@google.com
Subject: Re: [PATCH 1/2] tcp: fix races in tcp_abort()
Date: Fri, 14 Mar 2025 13:24:09 +0100 [thread overview]
Message-ID: <2025031453-underpay-gigahertz-9ba4@gregkh> (raw)
In-Reply-To: <20250314092446.852230-1-youngmin.nam@samsung.com>
On Fri, Mar 14, 2025 at 06:24:45PM +0900, Youngmin Nam wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> tcp_abort() has the same issue than the one fixed in the prior patch
> in tcp_write_err().
>
> commit 5ce4645c23cf5f048eb8e9ce49e514bababdee85 upstream.
>
> To apply commit bac76cf89816bff06c4ec2f3df97dc34e150a1c4,
> this patch must be applied first.
>
> In order to get consistent results from tcp_poll(), we must call
> sk_error_report() after tcp_done().
>
> We can use tcp_done_with_error() to centralize this logic.
>
> Fixes: c1e64e298b8c ("net: diag: Support destroying TCP sockets.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Acked-by: Neal Cardwell <ncardwell@google.com>
> Link: https://lore.kernel.org/r/20240528125253.1966136-4-edumazet@google.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Cc: <stable@vger.kernel.org> # v5.10+
Did not apply to 5.10.y, what did you want this added to?
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-14 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250314092125epcas2p418cd0caeffc32b05fba4fdd2e4ffb9fa@epcas2p4.samsung.com>
2025-03-14 9:24 ` [PATCH 1/2] tcp: fix races in tcp_abort() Youngmin Nam
2025-03-14 9:24 ` [PATCH 2/2] tcp: fix forever orphan socket caused by tcp_abort Youngmin Nam
2025-03-14 12:24 ` Greg KH
2025-03-17 4:32 ` Youngmin Nam
2025-03-14 12:24 ` Greg KH [this message]
2025-03-17 4:36 ` [PATCH 1/2] tcp: fix races in tcp_abort() Youngmin Nam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025031453-underpay-gigahertz-9ba4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cmllamas@google.com \
--cc=d7271.choe@samsung.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dujeong.lee@samsung.com \
--cc=edumazet@google.com \
--cc=gregkh@google.com \
--cc=guo88.liu@samsung.com \
--cc=hajun.sung@samsung.com \
--cc=horms@kernel.org \
--cc=joonki.min@samsung.com \
--cc=kuba@kernel.org \
--cc=kuro@kuroa.me \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=sw.ju@samsung.com \
--cc=willdeacon@google.com \
--cc=ycheng@google.com \
--cc=yiwang.cai@samsung.com \
--cc=youngmin.nam@samsung.com \
--cc=yyd@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox