From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B74719D07A for ; Mon, 17 Mar 2025 13:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742218412; cv=none; b=BA7SaAp/vdl+LERTGh41e4ixv5lOIO8wULwWBKn1qQCIIZCLpn/quQSpayRxCgJRLjXs/gMdI1t/1Z6S2Lk4jsslRzYRPcsZZLFJr+qMq55+HYel6gjfbWVdro3fFgx0JYqz988s3IJ8tRKAa8OJf5UrbXC0VOxpMY5DaK4YEGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742218412; c=relaxed/simple; bh=0FfSVCwWFYs03W9C6UYAiRgXVZq0hT3xfZFMsdgITK0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j3FP7mbt3GBmXr+pl3VvE2DgXb7i6w8oRQvsPEIsxbuc1Sxd9dr4vcAivLttC0WHn9VDjWXhY6lr7VA4Xk0kIiztUFdu119bXQKHw5ro2JFhVucBOak+PEUzGSfl1MNfVyJWe/1VdFAYRKYvvi2/TL3IDI0VrOSw2g8LpyFEuT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=YjD0FjxP; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="YjD0FjxP" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-22423adf751so68630355ad.2 for ; Mon, 17 Mar 2025 06:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1742218409; x=1742823209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZEfXjYWxniGhm4SvOUYnmezX7yQMhTQIadMZnGdIOxY=; b=YjD0FjxP/RN4CDHKyuG/eTr5xwOkGAVZhoEBF+DJfR9PYfi5l/IxjYgRwZYzGYtbIb QavP0XORbihWPbV9+ByBvNIU6TO+ry8tkwYKlmcZyCP0S6Y8tuqpOVtMlFiLCzggI0Yx 8Xz5ujW4GAGwzN+4me0e8peuqBotq35uSzSt9P0Pt3TmeY92RjwUIk3Yh6hCR9K6nDd4 F4oOiu+aaNjigGQ6isv6LbIcxYiUt9KjoNQ8Uy+B6kaJDsq3XUf0cu7eyyjNYxZCI1hz 6kO+zEphEf0gmBGQoQjGhsmkPHd/KWis7ccOfSgU+b2nBHpZL4xRLNZrxz2r3QY4q3RA r4Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742218409; x=1742823209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZEfXjYWxniGhm4SvOUYnmezX7yQMhTQIadMZnGdIOxY=; b=HzuSoGu5GXvjkui+3JkVVj7c8nwPCZbMnkkUm7W4e1kzkws4P3A4yiFIXU2HSP73wg Y0swxni+j0YidZXuwi2rIu3x/9xJhZzUw6Vf5qKgggqql+vT44fPFhfi6KsEndH7TupL /Vz+KAIksaGaNB9E56eQrsI32zlPFn+GF7hh7JdIeenDP148awBlaSzJKzN2lNYapY+o h/PzQIR4D2/V0jKFM1vm1oxCkLlAi366Px8gFUlJUza0Mxm3S/0iSpGaU2S8pwMgYsVC +1dSh5I+glMJpTp2yHVT7PlgJ0apFoE8IdNkjaAR1dF86PpP1aFXkIlA64mmVEbXvoaS dPlw== X-Gm-Message-State: AOJu0YwhrawtE/y77e0zgX93fZcYLy9o3+IcX7qwS+AGGlw9CFgkKRRQ Nu51Nd4UUiMnJOAkyq6Tj6Eqely10M/ttalBmgDXbpaUSCKtOYNTLI5ciObfFJo= X-Gm-Gg: ASbGncvlibc/o6F5ERZ0zlEN7rGggTIxnW4KvPv3K3hJfgTlUjFCDkWA4TSZ29SQbOJ L33TxLDf7buGMRepVbk6xeP3PVT5U2EmVY/fCIOoNkMvV6V2Xvie0FM4BfD5BKQbgLLnHPmq/lO FPLH5I8yeXlebCJBKtUhlvkzhZDMJofo2rLsBjbW0nt7g6R+vpq5SG48qp730EfLgJJz9GN+9Ps uv6zmb+12wQMlh6MqcQwW4c5azw4xlRrdTKX3xVnKzw8MRKo1eR3g/1ZiVKv7J0WO701ZeSRaJl RBLMXcbEdxJW4NyT+3vpMmKbLI8b4G19XdybRmxTB5cG+Mmkm+l2brAejB+uT4kfNxejD+wemy1 CvcyascoH1KbBWiHqarfS2A== X-Google-Smtp-Source: AGHT+IEmHbDYwAg4QRu3FCwOs605OWoP1Ex4sUzPy3ceNmpxuehNv0T9Y/bmDYd3OaHPBAiQ+SqmxA== X-Received: by 2002:a17:903:251:b0:224:24d3:60f4 with SMTP id d9443c01a7336-225e0a58081mr142708615ad.15.1742218409506; Mon, 17 Mar 2025 06:33:29 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7371167e17fsm7732985b3a.104.2025.03.17.06.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 06:33:29 -0700 (PDT) Date: Mon, 17 Mar 2025 06:33:26 -0700 From: Stephen Hemminger To: chia-yu.chang@nokia-bell-labs.com Cc: netdev@vger.kernel.org, dave.taht@gmail.com, pabeni@redhat.com, jhs@mojatatu.com, kuba@kernel.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, horms@kernel.org, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com, Olga Albisser , Oliver Tilmans , Bob Briscoe , Henrik Steen Subject: Re: [PATCH v4 iproute2-next 1/1] tc: add dualpi2 scheduler module Message-ID: <20250317063326.42e3e550@hermes.local> In-Reply-To: <20250316153917.21005-2-chia-yu.chang@nokia-bell-labs.com> References: <20250316153917.21005-1-chia-yu.chang@nokia-bell-labs.com> <20250316153917.21005-2-chia-yu.chang@nokia-bell-labs.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 16 Mar 2025 16:39:17 +0100 chia-yu.chang@nokia-bell-labs.com wrote: > +static int get_packets(uint32_t *val, const char *arg) > +{ > + unsigned long res; > + char *ptr; > + > + if (!arg || !*arg) > + return -1; > + res = strtoul(arg, &ptr, 10); > + if (!ptr || ptr == arg || > + (strcmp(ptr, "p") && strcmp(ptr, "pkt") && strcmp(ptr, "pkts") && > + strcmp(ptr, "packet") && strcmp(ptr, "packets"))) > + return -1; No shortcuts please. We ran into this with matches() and arg conflicts already.