* [PATCH 2/2] isdn: mISDN: Fix typo 'intervall' to 'interval' in hfcsusb.c
@ 2025-03-11 16:06 Suraj Patil
2025-03-17 17:56 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Suraj Patil @ 2025-03-11 16:06 UTC (permalink / raw)
To: isdn; +Cc: kuba, quic_jjohnson, netdev, linux-kernel, Suraj Patil
Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
---
drivers/isdn/hardware/mISDN/hfcsusb.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
index e54419a4e731..ebe57c190476 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.c
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
@@ -1063,7 +1063,7 @@ rx_iso_complete(struct urb *urb)
fill_isoc_urb(urb, fifo->hw->dev, fifo->pipe,
context_iso_urb->buffer, num_isoc_packets,
- fifo->usb_packet_maxlen, fifo->intervall,
+ fifo->usb_packet_maxlen, fifo->interval,
(usb_complete_t)rx_iso_complete, urb->context);
errcode = usb_submit_urb(urb, GFP_ATOMIC);
if (errcode < 0) {
@@ -1225,7 +1225,7 @@ tx_iso_complete(struct urb *urb)
sink = (threshbit) ? SINK_MIN : SINK_MAX;
fill_isoc_urb(urb, fifo->hw->dev, fifo->pipe,
context_iso_urb->buffer, num_isoc_packets,
- fifo->usb_packet_maxlen, fifo->intervall,
+ fifo->usb_packet_maxlen, fifo->interval,
(usb_complete_t)tx_iso_complete, urb->context);
memset(context_iso_urb->buffer, 0,
sizeof(context_iso_urb->buffer));
@@ -1355,7 +1355,7 @@ tx_iso_complete(struct urb *urb)
/*
* abuse DChannel tx iso completion to trigger NT mode state
* changes tx_iso_complete is assumed to be called every
- * fifo->intervall (ms)
+ * fifo->interval (ms)
*/
if ((fifon == HFCUSB_D_TX) && (hw->protocol == ISDN_P_NT_S0)
&& (hw->timers & NT_ACTIVATION_TIMER)) {
@@ -1411,7 +1411,7 @@ start_isoc_chain(struct usb_fifo *fifo, int num_packets_per_urb,
fifo->iso[i].buffer,
num_packets_per_urb,
fifo->usb_packet_maxlen,
- fifo->intervall, complete,
+ fifo->interval, complete,
&fifo->iso[i]);
memset(fifo->iso[i].buffer, 0,
sizeof(fifo->iso[i].buffer));
@@ -1510,7 +1510,7 @@ start_int_fifo(struct usb_fifo *fifo)
}
usb_fill_int_urb(fifo->urb, fifo->hw->dev, fifo->pipe,
fifo->buffer, fifo->usb_packet_maxlen,
- (usb_complete_t)rx_int_complete, fifo, fifo->intervall);
+ (usb_complete_t)rx_int_complete, fifo, fifo->interval);
fifo->active = 1;
fifo->stop_gracefull = 0;
errcode = usb_submit_urb(fifo->urb, GFP_KERNEL);
@@ -1596,7 +1596,7 @@ reset_hfcsusb(struct hfcsusb *hw)
handle_led(hw, LED_POWER_ON);
}
-/* start USB data pipes dependand on device's endpoint configuration */
+/* start USB data pipes dependent on device's endpoint configuration */
static void
hfcsusb_start_endpoint(struct hfcsusb *hw, int channel)
{
@@ -1664,7 +1664,7 @@ hfcsusb_start_endpoint(struct hfcsusb *hw, int channel)
}
}
-/* stop USB data pipes dependand on device's endpoint configuration */
+/* stop USB data pipes dependent on device's endpoint configuration */
static void
hfcsusb_stop_endpoint(struct hfcsusb *hw, int channel)
{
@@ -2077,7 +2077,7 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
f->hw = hw;
f->usb_packet_maxlen =
le16_to_cpu(ep->desc.wMaxPacketSize);
- f->intervall = ep->desc.bInterval;
+ f->interval = ep->desc.bInterval;
}
ep++;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] isdn: mISDN: Fix typo 'intervall' to 'interval' in hfcsusb.c
2025-03-11 16:06 [PATCH 2/2] isdn: mISDN: Fix typo 'intervall' to 'interval' in hfcsusb.c Suraj Patil
@ 2025-03-17 17:56 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2025-03-17 17:56 UTC (permalink / raw)
To: Suraj Patil; +Cc: isdn, kuba, quic_jjohnson, netdev, linux-kernel
On Tue, Mar 11, 2025 at 04:06:37PM +0000, Suraj Patil wrote:
> Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
> ---
> drivers/isdn/hardware/mISDN/hfcsusb.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
> index e54419a4e731..ebe57c190476 100644
> --- a/drivers/isdn/hardware/mISDN/hfcsusb.c
> +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
> @@ -1063,7 +1063,7 @@ rx_iso_complete(struct urb *urb)
>
> fill_isoc_urb(urb, fifo->hw->dev, fifo->pipe,
> context_iso_urb->buffer, num_isoc_packets,
> - fifo->usb_packet_maxlen, fifo->intervall,
> + fifo->usb_packet_maxlen, fifo->interval,
Perhaps it is addressed in patch 1/2 (which i am unable to locate), in
which case the relevant change should be folded into this patch to avoid
breaking bisection. But as this stands, with this patch (only) applied
builds fail because there is no member called interval in struct usb_fifo.
--
pw-bot: not-applicable
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-17 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-11 16:06 [PATCH 2/2] isdn: mISDN: Fix typo 'intervall' to 'interval' in hfcsusb.c Suraj Patil
2025-03-17 17:56 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).