* [PATCH net-next] qed: remove cast to pointers passed to kfree @ 2025-03-11 7:06 Chen Ni 2025-03-11 17:08 ` Michal Kubiak 2025-03-18 10:10 ` patchwork-bot+netdevbpf 0 siblings, 2 replies; 6+ messages in thread From: Chen Ni @ 2025-03-11 7:06 UTC (permalink / raw) To: manishc, andrew+netdev, davem, edumazet, kuba, pabeni Cc: netdev, linux-kernel, Chen Ni Remove unnecessary casts to pointer types passed to kfree. Issue detected by coccinelle: @@ type t1; expression *e; @@ -kfree((t1 *)e); +kfree(e); Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index f915c423fe70..886061d7351a 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -454,7 +454,7 @@ int qed_fill_dev_info(struct qed_dev *cdev, static void qed_free_cdev(struct qed_dev *cdev) { - kfree((void *)cdev); + kfree(cdev); } static struct qed_dev *qed_alloc_cdev(struct pci_dev *pdev) -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] qed: remove cast to pointers passed to kfree 2025-03-11 7:06 [PATCH net-next] qed: remove cast to pointers passed to kfree Chen Ni @ 2025-03-11 17:08 ` Michal Kubiak 2025-03-11 17:16 ` Michal Kubiak 2025-03-18 10:10 ` patchwork-bot+netdevbpf 1 sibling, 1 reply; 6+ messages in thread From: Michal Kubiak @ 2025-03-11 17:08 UTC (permalink / raw) To: Chen Ni Cc: manishc, andrew+netdev, davem, edumazet, kuba, pabeni, netdev, linux-kernel On Tue, Mar 11, 2025 at 03:06:24PM +0800, Chen Ni wrote: > Remove unnecessary casts to pointer types passed to kfree. > Issue detected by coccinelle: > @@ > type t1; > expression *e; > @@ > > -kfree((t1 *)e); > +kfree(e); > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c > index f915c423fe70..886061d7351a 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_main.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c > @@ -454,7 +454,7 @@ int qed_fill_dev_info(struct qed_dev *cdev, > > static void qed_free_cdev(struct qed_dev *cdev) > { > - kfree((void *)cdev); > + kfree(cdev); > } > > static struct qed_dev *qed_alloc_cdev(struct pci_dev *pdev) > -- > 2.25.1 > > LGTM. Thanks, Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] qed: remove cast to pointers passed to kfree 2025-03-11 17:08 ` Michal Kubiak @ 2025-03-11 17:16 ` Michal Kubiak 2025-03-17 18:56 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: Michal Kubiak @ 2025-03-11 17:16 UTC (permalink / raw) To: Chen Ni Cc: manishc, andrew+netdev, davem, edumazet, kuba, pabeni, netdev, linux-kernel On Tue, Mar 11, 2025 at 06:08:24PM +0100, Michal Kubiak wrote: > On Tue, Mar 11, 2025 at 03:06:24PM +0800, Chen Ni wrote: > > Remove unnecessary casts to pointer types passed to kfree. > > Issue detected by coccinelle: > > @@ > > type t1; > > expression *e; > > @@ > > > > -kfree((t1 *)e); > > +kfree(e); > > > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > > --- > > drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c > > index f915c423fe70..886061d7351a 100644 > > --- a/drivers/net/ethernet/qlogic/qed/qed_main.c > > +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c > > @@ -454,7 +454,7 @@ int qed_fill_dev_info(struct qed_dev *cdev, > > > > static void qed_free_cdev(struct qed_dev *cdev) > > { > > - kfree((void *)cdev); > > + kfree(cdev); > > } > > > > static struct qed_dev *qed_alloc_cdev(struct pci_dev *pdev) > > -- > > 2.25.1 > > > > > > > LGTM. > > Thanks, > Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> > I'm sorry I missed that the patch is addressed to "net-next". It rather looks like as a candidate for the "net" tree. Please resend it to the "net" tree with an appropriate "Fixes" tag. My apologies for the noise. Thanks, Michal ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] qed: remove cast to pointers passed to kfree 2025-03-11 17:16 ` Michal Kubiak @ 2025-03-17 18:56 ` Simon Horman 2025-03-18 9:26 ` Michal Kubiak 0 siblings, 1 reply; 6+ messages in thread From: Simon Horman @ 2025-03-17 18:56 UTC (permalink / raw) To: Michal Kubiak Cc: Chen Ni, manishc, andrew+netdev, davem, edumazet, kuba, pabeni, netdev, linux-kernel On Tue, Mar 11, 2025 at 06:16:41PM +0100, Michal Kubiak wrote: > On Tue, Mar 11, 2025 at 06:08:24PM +0100, Michal Kubiak wrote: > > On Tue, Mar 11, 2025 at 03:06:24PM +0800, Chen Ni wrote: > > > Remove unnecessary casts to pointer types passed to kfree. > > > Issue detected by coccinelle: > > > @@ > > > type t1; > > > expression *e; > > > @@ > > > > > > -kfree((t1 *)e); > > > +kfree(e); > > > > > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > > > --- > > > drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c > > > index f915c423fe70..886061d7351a 100644 > > > --- a/drivers/net/ethernet/qlogic/qed/qed_main.c > > > +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c > > > @@ -454,7 +454,7 @@ int qed_fill_dev_info(struct qed_dev *cdev, > > > > > > static void qed_free_cdev(struct qed_dev *cdev) > > > { > > > - kfree((void *)cdev); > > > + kfree(cdev); > > > } > > > > > > static struct qed_dev *qed_alloc_cdev(struct pci_dev *pdev) > > > -- > > > 2.25.1 > > > > > > > > > > > > LGTM. > > > > Thanks, > > Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> > > > > I'm sorry I missed that the patch is addressed to "net-next". > It rather looks like as a candidate for the "net" tree. > > Please resend it to the "net" tree with an appropriate "Fixes" tag. > > My apologies for the noise. Hi Michal, I'm unclear what bug this fixes. It seems to me that this is a clean-up. That as such it should only be considered in the context of more material changes to this driver. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] qed: remove cast to pointers passed to kfree 2025-03-17 18:56 ` Simon Horman @ 2025-03-18 9:26 ` Michal Kubiak 0 siblings, 0 replies; 6+ messages in thread From: Michal Kubiak @ 2025-03-18 9:26 UTC (permalink / raw) To: Simon Horman Cc: Chen Ni, manishc, andrew+netdev, davem, edumazet, kuba, pabeni, netdev, linux-kernel On Mon, Mar 17, 2025 at 06:56:22PM +0000, Simon Horman wrote: > On Tue, Mar 11, 2025 at 06:16:41PM +0100, Michal Kubiak wrote: > > On Tue, Mar 11, 2025 at 06:08:24PM +0100, Michal Kubiak wrote: > > > On Tue, Mar 11, 2025 at 03:06:24PM +0800, Chen Ni wrote: > > > > Remove unnecessary casts to pointer types passed to kfree. > > > > Issue detected by coccinelle: > > > > @@ > > > > type t1; > > > > expression *e; > > > > @@ > > > > > > > > -kfree((t1 *)e); > > > > +kfree(e); > > > > > > > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > > > > --- > > > > drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c > > > > index f915c423fe70..886061d7351a 100644 > > > > --- a/drivers/net/ethernet/qlogic/qed/qed_main.c > > > > +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c > > > > @@ -454,7 +454,7 @@ int qed_fill_dev_info(struct qed_dev *cdev, > > > > > > > > static void qed_free_cdev(struct qed_dev *cdev) > > > > { > > > > - kfree((void *)cdev); > > > > + kfree(cdev); > > > > } > > > > > > > > static struct qed_dev *qed_alloc_cdev(struct pci_dev *pdev) > > > > -- > > > > 2.25.1 > > > > > > > > > > > > > > > > > LGTM. > > > > > > Thanks, > > > Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> > > > > > > > I'm sorry I missed that the patch is addressed to "net-next". > > It rather looks like as a candidate for the "net" tree. > > > > Please resend it to the "net" tree with an appropriate "Fixes" tag. > > > > My apologies for the noise. > > Hi Michal, > > I'm unclear what bug this fixes. > > It seems to me that this is a clean-up. > That as such it should only be considered in the context > of more material changes to this driver. Hi Simon, I may have gone too far in stating from the commit message that "the issue was detected by coccinelle", so I considered it as a fix for the issue. I agree that it can be also considered as a clean-up, so if you don't see any problem I have no objection to sending it to "net-next". Thanks, Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] qed: remove cast to pointers passed to kfree 2025-03-11 7:06 [PATCH net-next] qed: remove cast to pointers passed to kfree Chen Ni 2025-03-11 17:08 ` Michal Kubiak @ 2025-03-18 10:10 ` patchwork-bot+netdevbpf 1 sibling, 0 replies; 6+ messages in thread From: patchwork-bot+netdevbpf @ 2025-03-18 10:10 UTC (permalink / raw) To: Chen Ni Cc: manishc, andrew+netdev, davem, edumazet, kuba, pabeni, netdev, linux-kernel Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Tue, 11 Mar 2025 15:06:24 +0800 you wrote: > Remove unnecessary casts to pointer types passed to kfree. > Issue detected by coccinelle: > @@ > type t1; > expression *e; > @@ > > [...] Here is the summary with links: - [net-next] qed: remove cast to pointers passed to kfree https://git.kernel.org/netdev/net-next/c/f5825e79b2b7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-18 10:09 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-03-11 7:06 [PATCH net-next] qed: remove cast to pointers passed to kfree Chen Ni 2025-03-11 17:08 ` Michal Kubiak 2025-03-11 17:16 ` Michal Kubiak 2025-03-17 18:56 ` Simon Horman 2025-03-18 9:26 ` Michal Kubiak 2025-03-18 10:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).