[PATCH net-next] net: skbuff: Remove unused skb_add_data()

[PATCH net-next] net: skbuff: Remove unused skb_add_data()

[Yue Haibing]

Since commit a4ea4c477619 ("rxrpc: Don't use a ring buffer for call Tx
queue") this function is not used anymore.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 include/linux/skbuff.h | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 14517e95a46c..bbc3b656c856 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -3865,25 +3865,6 @@ static inline int __must_check skb_put_padto(struct sk_buff *skb, unsigned int l
 bool csum_and_copy_from_iter_full(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i)
 	__must_check;
 
-static inline int skb_add_data(struct sk_buff *skb,
-			       struct iov_iter *from, int copy)
-{
-	const int off = skb->len;
-
-	if (skb->ip_summed == CHECKSUM_NONE) {
-		__wsum csum = 0;
-		if (csum_and_copy_from_iter_full(skb_put(skb, copy), copy,
-					         &csum, from)) {
-			skb->csum = csum_block_add(skb->csum, csum, off);
-			return 0;
-		}
-	} else if (copy_from_iter_full(skb_put(skb, copy), copy, from))
-		return 0;
-
-	__skb_trim(skb, off);
-	return -EFAULT;
-}
-
 static inline bool skb_can_coalesce(struct sk_buff *skb, int i,
 				    const struct page *page, int off)
 {
-- 
2.34.1

Re: [PATCH net-next] net: skbuff: Remove unused skb_add_data()

[Simon Horman]

On Wed, Mar 12, 2025 at 02:34:50PM +0800, Yue Haibing wrote:
> Since commit a4ea4c477619 ("rxrpc: Don't use a ring buffer for call Tx
> queue") this function is not used anymore.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] net: skbuff: Remove unused skb_add_data()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 12 Mar 2025 14:34:50 +0800 you wrote:
> Since commit a4ea4c477619 ("rxrpc: Don't use a ring buffer for call Tx
> queue") this function is not used anymore.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/linux/skbuff.h | 19 -------------------
>  1 file changed, 19 deletions(-)

Here is the summary with links:
  - [net-next] net: skbuff: Remove unused skb_add_data()
    https://git.kernel.org/netdev/net-next/c/24faa63bcea8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html