From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB5231A00F0 for ; Mon, 17 Mar 2025 20:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.95.48.154 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742242972; cv=none; b=fXr30871Z2TEQPlyQqffG4l2azs8ip82E4xxe3XEVjrK061F/3uSbv1VvjhzfB8yWiLJ7ri1zHx/4ET0+0xe8hqtaSQD2+zsvxPfwNyFwAQMZ/NTwKm3cMclW5sFsVjtatPBBC+ccLdn7y1mjYYMi8EU+45iekOOYE3G1BYlpB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742242972; c=relaxed/simple; bh=Mp7AVDMrS/ib2NF/YH9bK2zFL4l/UsQbiIoIfb2AIaQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ICx45mS5LxWwhzEm5I6/IGv/u3EMzNQ0RnTxiV3X9fOeE2NnlSAhc9dWgEsy8Enqpjh9UvCMUXu1oHJFQIo0iUaYwwnL3gaieemlixn4z94Y5nt+hBON5WuC8jamC9pqm1Q19PbLeKwCL1ZSYqiWE0Ng2mQFOeQQeu/lDIrOeIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b=THbJCqkm; arc=none smtp.client-ip=52.95.48.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="THbJCqkm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1742242971; x=1773778971; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=820PCY+r4yor30og4vk3YoLgyROldp4iQlCBKyu2L0c=; b=THbJCqkm7gIdKA0T4P3vLctVvqX8xSH0xPfh9hRsxYbmVJ6dRDdblTRT dDji7zL7kdcbaP9rrSFdwdzfwQUcjd3tYJpVfVP5nZG96yDPm+rtRcyaW xou75hgfAEhgfxZeq0oPxtqoDEZvfGgNAKZMK1937/YvHT7NjwjafweZq 4=; X-IronPort-AV: E=Sophos;i="6.14,254,1736812800"; d="scan'208";a="471856928" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2025 20:22:46 +0000 Received: from EX19MTAUWB001.ant.amazon.com [10.0.21.151:10468] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.40.101:2525] with esmtp (Farcaster) id 32a216dc-5857-47ef-8500-0bc594ddfe38; Mon, 17 Mar 2025 20:22:45 +0000 (UTC) X-Farcaster-Flow-ID: 32a216dc-5857-47ef-8500-0bc594ddfe38 Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX19MTAUWB001.ant.amazon.com (10.250.64.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Mon, 17 Mar 2025 20:22:45 +0000 Received: from 6c7e67bfbae3.amazon.com (10.106.100.54) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Mon, 17 Mar 2025 20:22:42 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , , Subject: Re: [PATCH net-next 1/2] tcp/dccp: remove icsk->icsk_timeout Date: Mon, 17 Mar 2025 13:21:56 -0700 Message-ID: <20250317202232.23864-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250317085313.2023214-1-edumazet@google.com> References: <20250317085313.2023214-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D033UWC003.ant.amazon.com (10.13.139.217) To EX19D004ANA001.ant.amazon.com (10.37.240.138) From: Eric Dumazet Date: Mon, 17 Mar 2025 15:14:00 +0000 > icsk->icsk_timeout can be replaced by icsk->icsk_retransmit_timer.expires > > This saves 8 bytes in TCP/DCCP sockets and helps for better cache locality. > > Signed-off-by: Eric Dumazet Reviewed-by: Kuniyuki Iwashima We may want to add a paired WRITE_ONCE() in __mod_timer() later. Btw, DCCP removal series is almost ready and I will post it in the next cycle as the patch queue is long now.