Re: [PATCH net-next v8 02/14] xsc: Enable command queue

[Simon Horman <horms@kernel.org>]

On Tue, Mar 18, 2025 at 06:06:07PM +0800, Xin Tian wrote:
> On 2025/3/12 17:17, Xin Tian wrote:
> > On 2025/3/10 14:34, Simon Horman wrote:
> >> On Fri, Mar 07, 2025 at 06:08:29PM +0800, Xin Tian wrote:
> >>> The command queue is a hardware channel for sending
> >>> commands between the driver and the firmware.
> >>> xsc_cmd.h defines the command protocol structures.
> >>> The logic for command allocation, sending,
> >>> completion handling, and error handling is implemented
> >>> in cmdq.c.
> >>>
> >>> Co-developed-by: Honggang Wei <weihg@yunsilicon.com>
> >>> Signed-off-by: Honggang Wei <weihg@yunsilicon.com>
> >>> Co-developed-by: Lei Yan <jacky@yunsilicon.com>
> >>> Signed-off-by: Lei Yan <jacky@yunsilicon.com>
> >>> Signed-off-by: Xin Tian <tianx@yunsilicon.com>
> >> Hi Xin,
> >>
> >> Some minor feedback from my side.
> >>
> >> ...
> >>
> >>> diff --git a/drivers/net/ethernet/yunsilicon/xsc/pci/cmdq.c b/drivers/net/ethernet/yunsilicon/xsc/pci/cmdq.c
> >> ...
> >>
> >>> +static int xsc_copy_to_cmd_msg(struct xsc_cmd_msg *to, void *from, int size)
> >>> +{
> >>> +	struct xsc_cmd_prot_block *block;
> >>> +	struct xsc_cmd_mailbox *next;
> >>> +	int copy;
> >>> +
> >>> +	if (!to || !from)
> >>> +		return -ENOMEM;
> >>> +
> >>> +	copy = min_t(int, size, sizeof(to->first.data));
> >> nit: I expect that using min() is sufficient here...
> > Ack
> 
> min(size, sizeof(to->first.data)) will lead to a compile warning.
> size is int and sizeof(to->first.data) is size_t.
> So I kept this in v9

Ack, thanks for checking.