From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <jdamato@fastly.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <horms@kernel.org>,
<kuba@kernel.org>, <kuni1840@gmail.com>, <kuniyu@amazon.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH v1 net-next 1/4] af_unix: Sort headers.
Date: Tue, 18 Mar 2025 16:50:00 -0700 [thread overview]
Message-ID: <20250318235208.57089-1-kuniyu@amazon.com> (raw)
In-Reply-To: <Z9n8w-6nXiBUI20T@LQ3V64L9R2>
From: Joe Damato <jdamato@fastly.com>
Date: Tue, 18 Mar 2025 16:07:47 -0700
> > +#include <linux/in.h>
> > #include <linux/init.h>
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +#include <linux/mount.h>
> > +#include <linux/namei.h>
> > +#include <linux/net.h>
> > +#include <linux/netdevice.h>
> > #include <linux/poll.h>
> > +#include <linux/proc_fs.h>
> > #include <linux/rtnetlink.h>
> > -#include <linux/mount.h>
> > -#include <net/checksum.h>
> > +#include <linux/sched/signal.h>
>
> Not sure what the sorting rules are, but I was wondering if maybe
> "linux/sched/*.h" should come after linux/*.h and not sorted within
> linux/s*.h ?
It's simply sorted in the alphabetial order.
Actually I haven't cared about the / level, so I grepped the
linux/sched/signal.h users and it looks like most didn't care.
grep -rnI --include=*.c --include=*.h "linux/sched/signal.h" -C 3
Thanks!
next prev parent reply other threads:[~2025-03-18 23:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 3:48 [PATCH v1 net-next 0/4] af_unix: Clean up headers Kuniyuki Iwashima
2025-03-18 3:48 ` [PATCH v1 net-next 1/4] af_unix: Sort headers Kuniyuki Iwashima
2025-03-18 23:07 ` Joe Damato
2025-03-18 23:50 ` Kuniyuki Iwashima [this message]
2025-03-19 15:56 ` Joe Damato
2025-03-18 3:48 ` [PATCH v1 net-next 2/4] af_unix: Move internal definitions to net/unix/ Kuniyuki Iwashima
2025-03-18 23:12 ` Joe Damato
2025-03-19 17:49 ` Willem de Bruijn
2025-03-19 18:15 ` Kuniyuki Iwashima
2025-03-19 19:48 ` Willem de Bruijn
2025-03-18 3:48 ` [PATCH v1 net-next 3/4] af_unix: Explicitly include headers for non-pointer struct fields Kuniyuki Iwashima
2025-03-18 3:48 ` [PATCH v1 net-next 4/4] af_unix: Clean up #include under net/unix/ Kuniyuki Iwashima
2025-03-25 11:40 ` [PATCH v1 net-next 0/4] af_unix: Clean up headers patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318235208.57089-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).