Re: [PATCH v5 0/8] Introduce fwctl subystem

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Mar 17, 2025 at 08:33:04PM +0000, Keller, Jacob E wrote:
> 
> 
> > -----Original Message-----
> > From: David Ahern <dsahern@kernel.org>
> > Sent: Monday, March 17, 2025 12:01 PM
> > To: Jason Gunthorpe <jgg@nvidia.com>; Keller, Jacob E
> > <jacob.e.keller@intel.com>
> > Cc: Nelson, Shannon <shannon.nelson@amd.com>; Leon Romanovsky
> > <leon@kernel.org>; Jiri Pirko <jiri@resnulli.us>; Jakub Kicinski
> > <kuba@kernel.org>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Andy
> > Gospodarek <andrew.gospodarek@broadcom.com>; Aron Silverton
> > <aron.silverton@oracle.com>; Williams, Dan J <dan.j.williams@intel.com>; Daniel
> > Vetter <daniel.vetter@ffwll.ch>; Jiang, Dave <dave.jiang@intel.com>; Christoph
> > Hellwig <hch@infradead.org>; Itay Avraham <itayavr@nvidia.com>; Jiri Pirko
> > <jiri@nvidia.com>; Jonathan Cameron <Jonathan.Cameron@huawei.com>;
> > Leonid Bloch <lbloch@nvidia.com>; linux-cxl@vger.kernel.org; linux-
> > rdma@vger.kernel.org; netdev@vger.kernel.org; Saeed Mahameed
> > <saeedm@nvidia.com>; Sinyuk, Konstantin <konstantin.sinyuk@intel.com>
> > Subject: Re: [PATCH v5 0/8] Introduce fwctl subystem
> > 
> > On 3/17/25 1:33 PM, Jason Gunthorpe wrote:
> > > On Fri, Mar 14, 2025 at 11:09:47AM -0700, Jacob Keller wrote:
> > >
> > >> I'd throw my hat in for drivers/core as well, I think it makes the most
> > >> sense and is the most subsystem neutral name. Hopefully any issue with
> > >> tooling can be solved relatively easily.
> > >
> > > Given Greg's point about core dump files sometimes being in .gitignore
> > > maybe "shared_core", or something along that path is a better name?
> > >
> > 
> > Not seeing the conflict on drivers/core:
> > 
> > $ find . -name .gitignore | xargs grep core
> > ./tools/testing/selftests/powerpc/ptrace/.gitignore:core-pkey
> > ./tools/testing/selftests/cgroup/.gitignore:test_core
> > ./tools/testing/selftests/mincore/.gitignore:mincore_selftest
> > ./arch/mips/crypto/.gitignore:poly1305-core.S
> > ./arch/arm/crypto/.gitignore:aesbs-core.S
> > ./arch/arm/crypto/.gitignore:sha256-core.S
> > ./arch/arm/crypto/.gitignore:sha512-core.S
> > ./arch/arm/crypto/.gitignore:poly1305-core.S
> > ./arch/arm64/crypto/.gitignore:sha256-core.S
> > ./arch/arm64/crypto/.gitignore:sha512-core.S
> > ./arch/arm64/crypto/.gitignore:poly1305-core.S
> 
> I would guess its people putting core in their own ignore lists, not necessarily what we commit to the kernel tree.

Yes, note, the issue came up in the 2.5.x kernel days, _WAY_ before we
had git, so this wasn't a git issue.  I'm all for "drivers/core/" but
note, that really looks like "the driver core" area of the kernel, so
maybe pick a different name?

Maybe drivers/lib/ as this is common stuff for a variety of different
drivers?  I don't know, naming is hard, sorry.  I've been defaulting to
just using dutch words for projects these days as they don't seem to be
used much.  Hey, that might work here, drivers/kern/ perhaps?  Nah...

thanks,

greg k-h