From: Simon Horman <horms@kernel.org>
To: pwn9uin@gmail.com
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Minjoong Kim <alswnd4123@outlook.kr>
Subject: Re: [PATCH net] atm: null pointer dereference when both entry and holding_time are NULL.
Date: Wed, 19 Mar 2025 12:03:20 +0000 [thread overview]
Message-ID: <20250319120320.GA280585@kernel.org> (raw)
In-Reply-To: <20250314003404.16408-1-pwn9uin@gmail.com>
On Fri, Mar 14, 2025 at 12:34:04AM +0000, pwn9uin@gmail.com wrote:
> From: Minjoong Kim <alswnd4123@outlook.kr>
>
> When MPOA_cache_impos_rcvd() receives the msg, it can trigger
> Null Pointer Dereference Vulnerability if both entry and
> holding_time are NULL. Because there is only for the situation
> where entry is NULL and holding_time exists, it can be passed
> when both entry and holding_time are NULL. If these are NULL,
> the entry will be passd to eg_cache_put() as parameter and
> it is referenced by entry->use code in it.
>
> Signed-off-by: Minjoong Kim <alswnd4123@outlook.kr>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Hi,
I agree this is a theoretical possibility, but can it occur in practice?
Have you observed this problem? I think some analysis of that is warranted.
Also, Smatch tells me that there is a potential dereference of mpc while
NULL. Perhaps you could look at making a patch for that too?
next prev parent reply other threads:[~2025-03-19 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 0:34 [PATCH net] atm: null pointer dereference when both entry and holding_time are NULL pwn9uin
2025-03-19 12:03 ` Simon Horman [this message]
2025-03-20 9:36 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319120320.GA280585@kernel.org \
--to=horms@kernel.org \
--cc=alswnd4123@outlook.kr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pwn9uin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).