From: Simon Horman <horms@kernel.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net 3/3] mptcp: sockopt: fix getting freebind & transparent
Date: Wed, 19 Mar 2025 15:39:20 +0000 [thread overview]
Message-ID: <20250319153920.GD768132@kernel.org> (raw)
In-Reply-To: <20250314-net-mptcp-fix-data-stream-corr-sockopt-v1-3-122dbb249db3@kernel.org>
On Fri, Mar 14, 2025 at 09:11:33PM +0100, Matthieu Baerts (NGI0) wrote:
> When adding a socket option support in MPTCP, both the get and set parts
> are supposed to be implemented.
>
> IP(V6)_FREEBIND and IP(V6)_TRANSPARENT support for the setsockopt part
> has been added a while ago, but it looks like the get part got
> forgotten. It should have been present as a way to verify a setting has
> been set as expected, and not to act differently from TCP or any other
> socket types.
>
> Everything was in place to expose it, just the last step was missing.
> Only new code is added to cover these specific getsockopt(), that seems
> safe.
>
> Fixes: c9406a23c116 ("mptcp: sockopt: add SOL_IP freebind & transparent options")
> Cc: stable@vger.kernel.org
> Reviewed-by: Mat Martineau <martineau@kernel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Hi Matthieu, all,
As per my comment on patch 2/3, I would lean towards this being net-next
material rather than a fix for net. But that notwithstanding this looks
good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-03-19 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 20:11 [PATCH net 0/3] mptcp: fix data stream corruption and missing sockopts Matthieu Baerts (NGI0)
2025-03-14 20:11 ` [PATCH net 1/3] mptcp: Fix data stream corruption in the address announcement Matthieu Baerts (NGI0)
2025-03-19 15:37 ` Simon Horman
2025-03-19 15:39 ` Simon Horman
2025-03-14 20:11 ` [PATCH net 2/3] mptcp: sockopt: fix getting IPV6_V6ONLY Matthieu Baerts (NGI0)
2025-03-19 15:38 ` Simon Horman
2025-03-19 16:26 ` Matthieu Baerts
2025-03-20 12:55 ` Paolo Abeni
2025-03-20 12:58 ` Simon Horman
2025-03-14 20:11 ` [PATCH net 3/3] mptcp: sockopt: fix getting freebind & transparent Matthieu Baerts (NGI0)
2025-03-19 15:39 ` Simon Horman [this message]
2025-03-20 14:20 ` [PATCH net 0/3] mptcp: fix data stream corruption and missing sockopts patchwork-bot+netdevbpf
2025-03-21 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319153920.GD768132@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).