netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: tang.dongxing@zte.com.cn
Cc: krzk@kernel.org, davem@davemloft.net, feng.wei8@zte.com.cn,
	shao.mingyin@zte.com.cn, xie.ludan@zte.com.cn,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	yang.guang5@zte.com.cn, yang.yang29@zte.com.cn,
	ye.xingchen@zte.com.cn, xu.xin16@zte.com.cn
Subject: Re: [PATCH] net: atm: use sysfs_emit_at() instead of scnprintf()
Date: Thu, 20 Mar 2025 11:42:53 +0000	[thread overview]
Message-ID: <20250320114253.GJ280585@kernel.org> (raw)
In-Reply-To: <20250317170902154iQh7_gBiO8KjCrFrhnAqn@zte.com.cn>

On Mon, Mar 17, 2025 at 05:09:02PM +0800, tang.dongxing@zte.com.cn wrote:
> >On 17/03/2025 08:51, tang.dongxing@zte.com.cn wrote:> From: TangDongxing <tang.dongxing@zte.com.cn>
> >> 
> >> Follow the advice in Documentation/filesystems/sysfs.rst:
> >> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> >> the value to be returned to user space.
> >> 
> >> Signed-off-by: Tang Dongxing <tang.dongxing@zte.com.cn>Dear ZTE,
> >
> >Can you slow down? You sent a bunch of emails with similar issues which
> >means that dozen of maintainers will deal with the same issues
> >independently. This looks like another vivo or huawei style submission,
> >leading to bugs sneaked via flood of patches.
> >
> >First, fix the name used in the SoB (see submitting patches) to match
> >Latin transcription.
> >
> >Second, use proper SoB chain, see submitting patches.
> >
> >Third, really, really be sure that what you send is correct. You already
> >got quite responses, but you still keep sending patches.
> >
> >Fourth, respond to received feedback instead of flooding us with more of
> >this!
> 
> Dear Krzysztof,
> Thank you for your feedback. I apologize for my previous submissions.
> Regarding the issues you've pointed out:
> I will correct the name used in the SoB to ensure it matches the Latin transcription as required.
> I will double-check my work before sending any further updates.
> I appreciate your guidance and will follow the submission guidelines more carefully going forward. If you have any further advice or resources to help me improve my submissions, I would be grateful for your input.
> Best regards, 
> Tang Dongxing

Thanks Tang Dongxing,

Further to Krzystof's comments: please coordinate with your colleague
Xie Ludan who has also posted a patch in this area.

  https://lore.kernel.org/all/20250317152933756kWrF1Y_e-2EKtrR_GGegq@zte.com.cn/

It will be much easier for review if there is a single patch
that addresses these issues for ATM.

Also, please consider reading the following guidance on processes
for the networking subsystem of the Linux kernel. These are similar
but different to other subsystems.

  https://docs.kernel.org/process/maintainer-netdev.html

-- 
pw-bot: changes-requested

  reply	other threads:[~2025-03-20 11:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17  7:51 [PATCH] net: atm: use sysfs_emit_at() instead of scnprintf() tang.dongxing
2025-03-17  8:16 ` Krzysztof Kozlowski
2025-03-17  9:09   ` tang.dongxing
2025-03-20 11:42     ` Simon Horman [this message]
2025-03-21  2:45       ` tang.dongxing
2025-03-25 15:27         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250320114253.GJ280585@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=feng.wei8@zte.com.cn \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shao.mingyin@zte.com.cn \
    --cc=tang.dongxing@zte.com.cn \
    --cc=xie.ludan@zte.com.cn \
    --cc=xu.xin16@zte.com.cn \
    --cc=yang.guang5@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    --cc=ye.xingchen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).