From: Simon Horman <horms@kernel.org>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: netdev@vger.kernel.org, jeroendb@google.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, pkaligineedi@google.com,
shailend@google.com, willemb@google.com,
jacob.e.keller@intel.com, joshwash@google.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] gve: unlink old napi only if page pool exists
Date: Thu, 20 Mar 2025 17:25:08 +0000 [thread overview]
Message-ID: <20250320172508.GD892515@horms.kernel.org> (raw)
In-Reply-To: <20250317214141.286854-1-hramamurthy@google.com>
On Mon, Mar 17, 2025 at 09:41:41PM +0000, Harshitha Ramamurthy wrote:
> Commit de70981f295e ("gve: unlink old napi when stopping a queue using
> queue API") unlinks the old napi when stopping a queue. But this breaks
> QPL mode of the driver which does not use page pool. Fix this by checking
> that there's a page pool associated with the ring.
>
> Cc: stable@vger.kernel.org
> Fixes: de70981f295e ("gve: unlink old napi when stopping a queue using queue API")
> Reviewed-by: Joshua Washington <joshwash@google.com>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-03-20 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 21:41 [PATCH net] gve: unlink old napi only if page pool exists Harshitha Ramamurthy
2025-03-20 17:25 ` Simon Horman [this message]
2025-03-24 19:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320172508.GD892515@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=stable@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).