From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929D435893 for ; Sun, 23 Mar 2025 16:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742748830; cv=none; b=rVSSQkmkDr+bbZofkHD+GMoztRQz4/KaGFQvw7uXGW12JI4QFkRgSPMIKYib/X7yKx9Sbq3MKcTgBYu94e0Pxz5S+T1wVYARkj0C42MlS5/55BUwVEQLsmaiNmLGY4hA4LNFhk/IoCgRkq/xjXIbmpACc8W3pAl1djagKigXIno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742748830; c=relaxed/simple; bh=FQHrLpe1heNBZ7ovfW2w/wuecLHQdWzjb611CA1ILak=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dxJ8xjnvLM4zwDV5hZoPkbbvt5Sbu77lfbQjqdRw4Jd5zGPVtWhYBYcj8fjwWqdthmzVlBsPthLx1YNCrLMhY1DgtJ87V7SQwAMvvx/uqDboI//4ZfrPc4O4vUAgZtMu7BOYipDWD3HLiMe2B0RRMX4SZoJseamPvfclu1QPm2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OWSeRnGg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OWSeRnGg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07824C4CEE2; Sun, 23 Mar 2025 16:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742748830; bh=FQHrLpe1heNBZ7ovfW2w/wuecLHQdWzjb611CA1ILak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OWSeRnGgDZoa+FD2Jftwn6ddLmXFu3Jerwphx/0OhnscY6XARxNxvxXcqlQXzQ7xF FcYrNXbtk0ImF24O+5p22ihIzNQHxzG0bVcX3Gi+ezG8fkczRsjJz1C/5y9xIWbMQx GnAgOxxBYmkIlnjBZerNKmjNggo+i1b49LrPiq/R1NJGAvqFNaqiJaBtVtmyNv20z5 7S1jr7lFyiejzAm/UZS/dp1KTeIXZbck9camtxLVqCtY4hhosfkPPo4bX5jeQP/4Bq NjJ/hm0drOA/cMzkC1qYlzmYo0DjLRz4BZHvmAVFXYpwkhjJNbEm0p351XmSwa93NV YkakNHneLlVrw== Date: Sun, 23 Mar 2025 16:53:45 +0000 From: Simon Horman To: Eric Dumazet Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , David Ahern , netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net-next] ipv6: fix _DEVADD() and _DEVUPD() macros Message-ID: <20250323165345.GS892515@horms.kernel.org> References: <20250319212516.2385451-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250319212516.2385451-1-edumazet@google.com> On Wed, Mar 19, 2025 at 09:25:16PM +0000, Eric Dumazet wrote: > ip6_rcv_core() is using: > > __IP6_ADD_STATS(net, idev, > IPSTATS_MIB_NOECTPKTS + > (ipv6_get_dsfield(hdr) & INET_ECN_MASK), > max_t(unsigned short, 1, skb_shinfo(skb)->gso_segs)); > > This is currently evaluating both expressions twice. > > Fix _DEVADD() and _DEVUPD() macros to evaluate their arguments once. > > Signed-off-by: Eric Dumazet Reviewed-by: Simon Horman