From: Rob Herring <robh@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Rasmus Villemoes <ravi@prevas.dk>,
Colin Foster <colin.foster@in-advantage.com>,
devicetree@vger.kernel.org,
Felix Blix Everberg <felix.blix@prevas.dk>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: net: mscc,vsc7514-switch: allow specifying 'phys' for switch ports
Date: Mon, 24 Mar 2025 09:39:53 -0500 [thread overview]
Message-ID: <20250324143953.GA11614-robh@kernel.org> (raw)
In-Reply-To: <20250324100055.rqx4rle6fdtn7dg2@skbuf>
On Mon, Mar 24, 2025 at 12:00:55PM +0200, Vladimir Oltean wrote:
> On Mon, Mar 24, 2025 at 09:55:06AM +0100, Rasmus Villemoes wrote:
> > Ports that use SGMII / QSGMII to interface to external phys (or as
> > fixed-link to a cpu mac) need to configure the internal SerDes
> > interface appropriately. Allow an optional 'phys' property to describe
> > those relationships.
> >
> > Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
> > ---
>
> Oops... I had thought 'phys' and 'phy-names' would be part of
> Documentation/devicetree/bindings/net/ethernet-controller.yaml...
>
> By the way, should you also accept 'phy-names' in the binding?
No. There's only 1 phy, so not needed.
next prev parent reply other threads:[~2025-03-24 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 8:55 [PATCH 0/2] dt-bindings: net: mscc,vsc7514-switch: allow specifying 'phys' for switch ports Rasmus Villemoes
2025-03-24 8:55 ` [PATCH 1/2] Revert "dt-bindings: net: mscc,vsc7514-switch: Simplify DSA and switch references" Rasmus Villemoes
2025-03-24 14:41 ` Rob Herring
2025-03-24 8:55 ` [PATCH 2/2] dt-bindings: net: mscc,vsc7514-switch: allow specifying 'phys' for switch ports Rasmus Villemoes
2025-03-24 10:00 ` Vladimir Oltean
2025-03-24 14:39 ` Rob Herring [this message]
2025-03-24 14:21 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324143953.GA11614-robh@kernel.org \
--to=robh@kernel.org \
--cc=colin.foster@in-advantage.com \
--cc=devicetree@vger.kernel.org \
--cc=felix.blix@prevas.dk \
--cc=netdev@vger.kernel.org \
--cc=ravi@prevas.dk \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).