From: Jakub Kicinski <kuba@kernel.org>
To: Jiayuan Chen <jiayuan.chen@linux.dev>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com, kuniyu@amazon.com, davem@davemloft.net,
pabeni@redhat.com, horms@kernel.org, dsahern@kernel.org,
ncardwell@google.com, mrpre@163.com
Subject: Re: [PATCH net-next v1] tcp: Support skb PAWS drop reason when TIME-WAIT
Date: Tue, 25 Mar 2025 03:58:05 -0700 [thread overview]
Message-ID: <20250325035805.202ffe52@kernel.org> (raw)
In-Reply-To: <20250324131805.23103-1-jiayuan.chen@linux.dev>
On Mon, 24 Mar 2025 21:18:05 +0800 Jiayuan Chen wrote:
> When the server actively closes a connection and enters the TIME_WAIT
> state, if PAWS validation fails, the discarded skb previously lacked a
> corresponding reason identifier. This commit assigns the existing
> SKB_DROP_REASON_TCP_RFC7323_PAWS as the reason for such drops.
>
> We use 'pwru' to capture drop reason.
This patch does not apply cleanly to net-next:
Applying: tcp: Support skb PAWS drop reason when TIME-WAIT
Using index info to reconstruct a base tree...
M include/net/tcp.h
M net/ipv4/tcp_ipv4.c
M net/ipv4/tcp_minisocks.c
M net/ipv6/tcp_ipv6.c
Falling back to patching base and 3-way merge...
Auto-merging net/ipv6/tcp_ipv6.c
CONFLICT (content): Merge conflict in net/ipv6/tcp_ipv6.c
Auto-merging net/ipv4/tcp_minisocks.c
Auto-merging net/ipv4/tcp_ipv4.c
CONFLICT (content): Merge conflict in net/ipv4/tcp_ipv4.c
Auto-merging include/net/tcp.h
Recorded preimage for 'net/ipv4/tcp_ipv4.c'
Recorded preimage for 'net/ipv6/tcp_ipv6.c'
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 tcp: Support skb PAWS drop reason when TIME-WAIT
--
pw-bot: cr
prev parent reply other threads:[~2025-03-25 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 13:18 [PATCH net-next v1] tcp: Support skb PAWS drop reason when TIME-WAIT Jiayuan Chen
2025-03-25 10:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325035805.202ffe52@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrpre@163.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).