From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH net-next] netpoll: optimize struct layout for cache efficiency
Date: Tue, 25 Mar 2025 10:00:17 -0700 [thread overview]
Message-ID: <20250325100017.257cb04b@kernel.org> (raw)
In-Reply-To: <20250325-just-sloth-of-examination-7cd2df@leitao>
On Tue, 25 Mar 2025 09:50:21 -0700 Breno Leitao wrote:
> > It's a little odd to leave the tracker in hot data, if you do it
> > should at least be adjacent to the pointer it tracks?
>
> Double-checking this better, netdevice_tracker is NOT on the hot path.
> It is only used on the setup functions.
>
> If you think this is not a total waste of time, I will send a v2 moving
> it to the bottom.
I'd keep it next to dev. A bit of packing to save space is fine,
but let's prioritize readability during the reshuffle.
Note that net-next is closed for the MW.
prev parent reply other threads:[~2025-03-25 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:29 [PATCH net-next] netpoll: optimize struct layout for cache efficiency Breno Leitao
2025-03-25 15:48 ` Jakub Kicinski
2025-03-25 16:50 ` Breno Leitao
2025-03-25 17:00 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325100017.257cb04b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).