netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net v2] net: Fix the devmem sock opts and msgs for parisc
@ 2025-03-24  7:42 Pranjal Shrivastava
  2025-03-25 19:26 ` Jakub Kicinski
  2025-03-25 19:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Pranjal Shrivastava @ 2025-03-24  7:42 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman
  Cc: netdev, linux-parisc, Willem de Bruijn, Mina Almasry,
	Pranjal Shrivastava, Jason Xing

The devmem socket options and socket control message definitions
introduced in the TCP devmem series[1] incorrectly continued the socket
definitions for arch/parisc.

The UAPI change seems safe as there are currently no drivers that
declare support for devmem TCP RX via PP_FLAG_ALLOW_UNREADABLE_NETMEM.
Hence, fixing this UAPI should be safe.

Fix the devmem socket options and socket control message definitions to
reflect the series followed by arch/parisc.

[1]
https://lore.kernel.org/lkml/20240910171458.219195-10-almasrymina@google.com/

Fixes: 8f0b3cc9a4c10 ("tcp: RX path for devmem TCP")
Signed-off-by: Pranjal Shrivastava <praan@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Reviewed-by: Mina Almasry <almasrymina@google.com>
---
 arch/parisc/include/uapi/asm/socket.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/parisc/include/uapi/asm/socket.h b/arch/parisc/include/uapi/asm/socket.h
index aa9cd4b951fe..96831c988606 100644
--- a/arch/parisc/include/uapi/asm/socket.h
+++ b/arch/parisc/include/uapi/asm/socket.h
@@ -132,16 +132,16 @@
 #define SO_PASSPIDFD		0x404A
 #define SO_PEERPIDFD		0x404B
 
-#define SO_DEVMEM_LINEAR	78
-#define SCM_DEVMEM_LINEAR	SO_DEVMEM_LINEAR
-#define SO_DEVMEM_DMABUF	79
-#define SCM_DEVMEM_DMABUF	SO_DEVMEM_DMABUF
-#define SO_DEVMEM_DONTNEED	80
-
 #define SCM_TS_OPT_ID		0x404C
 
 #define SO_RCVPRIORITY		0x404D
 
+#define SO_DEVMEM_LINEAR	0x404E
+#define SCM_DEVMEM_LINEAR	SO_DEVMEM_LINEAR
+#define SO_DEVMEM_DMABUF	0x404F
+#define SCM_DEVMEM_DMABUF	SO_DEVMEM_DMABUF
+#define SO_DEVMEM_DONTNEED	0x4050
+
 #if !defined(__KERNEL__)
 
 #if __BITS_PER_LONG == 64
-- 
2.49.0.395.g12beb8f557-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net v2] net: Fix the devmem sock opts and msgs for parisc
  2025-03-24  7:42 [PATCH net v2] net: Fix the devmem sock opts and msgs for parisc Pranjal Shrivastava
@ 2025-03-25 19:26 ` Jakub Kicinski
  2025-03-25 19:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2025-03-25 19:26 UTC (permalink / raw)
  To: Pranjal Shrivastava
  Cc: David S . Miller, Eric Dumazet, Paolo Abeni, Simon Horman, netdev,
	linux-parisc, Willem de Bruijn, Mina Almasry, Jason Xing

On Mon, 24 Mar 2025 07:42:27 +0000 Pranjal Shrivastava wrote:
> The UAPI change seems safe as there are currently no drivers that
> declare support for devmem TCP RX via PP_FLAG_ALLOW_UNREADABLE_NETMEM.

... that could possibly work on parisc.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net v2] net: Fix the devmem sock opts and msgs for parisc
  2025-03-24  7:42 [PATCH net v2] net: Fix the devmem sock opts and msgs for parisc Pranjal Shrivastava
  2025-03-25 19:26 ` Jakub Kicinski
@ 2025-03-25 19:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-03-25 19:50 UTC (permalink / raw)
  To: Pranjal Shrivastava
  Cc: davem, edumazet, kuba, pabeni, horms, netdev, linux-parisc,
	willemb, almasrymina, kerneljasonxing

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 24 Mar 2025 07:42:27 +0000 you wrote:
> The devmem socket options and socket control message definitions
> introduced in the TCP devmem series[1] incorrectly continued the socket
> definitions for arch/parisc.
> 
> The UAPI change seems safe as there are currently no drivers that
> declare support for devmem TCP RX via PP_FLAG_ALLOW_UNREADABLE_NETMEM.
> Hence, fixing this UAPI should be safe.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: Fix the devmem sock opts and msgs for parisc
    https://git.kernel.org/netdev/net/c/fd87b7783802

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-03-25 19:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-24  7:42 [PATCH net v2] net: Fix the devmem sock opts and msgs for parisc Pranjal Shrivastava
2025-03-25 19:26 ` Jakub Kicinski
2025-03-25 19:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).