From: Jakub Kicinski <kuba@kernel.org>
To: Pablo Martin Medrano <pablmart@redhat.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>, Petr Machata <petrm@nvidia.com>,
Filippo Storniolo <fstornio@redhat.com>
Subject: Re: [PATCH net v4] selftests/net: big_tcp: return xfail on slow machines
Date: Tue, 25 Mar 2025 13:38:50 -0700 [thread overview]
Message-ID: <20250325133850.1d503348@kernel.org> (raw)
In-Reply-To: <aee7724405df4516494d687a5cb1835aeb309bd3.1742841907.git.pablmart@redhat.com>
On Mon, 24 Mar 2025 19:54:02 +0100 Pablo Martin Medrano wrote:
> After debugging the following output for big_tcp.sh on a board:
>
> CLI GSO | GW GRO | GW GSO | SER GRO
> on on on on : [PASS]
> on off on off : [PASS]
> off on on on : [FAIL_on_link1]
> on on off on : [FAIL_on_link1]
>
> Davide Caratti found that by default the test duration 1s is too short
> in slow systems to reach the correct cwd size necessary for tcp/ip to
> generate at least one packet bigger than 65536 (matching the iptables
> match on length rule the test evaluates)
>
> This skips (with xfail) the aforementioned failing combinations when
> KSFT_MACHINE_SLOW is set. For that the test has been modified to use
> facilities from net/lib.sh.
>
> The new output for the test will look like this (example with a forced
> XFAIL)
Sorry I was AFK for 2 weeks, what happened to my suggestions of using
byte count rather than time ?
prev parent reply other threads:[~2025-03-25 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 18:54 [PATCH net v4] selftests/net: big_tcp: return xfail on slow machines Pablo Martin Medrano
2025-03-25 11:09 ` Petr Machata
2025-03-25 20:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325133850.1d503348@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fstornio@redhat.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablmart@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).